Bug 140208 - Frame and content split after undo change 'as character' 'to character (DOCX)
Summary: Frame and content split after undo change 'as character' 'to character (DOCX)
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: DOCX-Textbox Undo-Redo
  Show dependency tree / graph
 
Reported: 2021-02-06 08:44 UTC by Telesto
Modified: 2021-09-17 07:03 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:

Attachments
Screenshot of the original document and its docx version in Writer after undo anchor change (296.54 KB, image/png)
2021-02-08 09:11 UTC, NISZ LibreOffice Team 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-02-06 08:44:18 UTC 
Description:
Frame and content split after undo change 'as character' 'to character

Steps to Reproduce:
1. Open attachment 163564 [details]
2. Save as DOCX
3. File reload
4. Go to figure 7: change anchor to character
5. Press undo

Actual Results:
Split frame

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-02-06 08:47:08 UTC 
Also in
Version: 6.5.0.0.alpha0+ (x64)
Build ID: 568b820bc2d52c007ee08ad7a3849c94a458115d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 2 Telesto 2021-02-06 08:48:20 UTC 
Adding bibisect request.. but more to compare variants of brokenness
Comment 3 NISZ LibreOffice Team 2021-02-08 09:11:53 UTC 
Created attachment 169577 [details]
Screenshot of the original document and its docx version in Writer after undo anchor change

Repro in:

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-GB
Calc: CL
Comment 4 Buovjaga 2021-04-08 15:22:52 UTC 
Bibisected with linux-64-6.4 to https://git.libreoffice.org/core/commit/09228fabe88f3457105cf26d83c003719a793114
sw undo/redo: avoid usage of pointers as a style references

Adding Cc: to Vasily Melenchuk

I guess the behaviour changed a bit at a later point, but it is more or less the same.
Comment 5 NISZ LibreOffice Team 2021-04-23 12:12:23 UTC 
This got better after

https://cgit.freedesktop.org/libreoffice/core/commit/?id=cb965f2cf6d68c284ccbd8a9635abfdfcc0538ca

tdf#141550 tdf#141557 tdf#140975 sw: fix textbox crash

Now:

4. Go to figure 7: change anchor to character

* Makes the frame and content split (just like before; let's keep this bug open for this part!),
* But undo no longer pushes the figure 7 up to the second pages header from the bottom of it, but restores the original layout.

Also changing meta; this is not a frame issue after saving a frame to docx & reload.
Comment 6 NISZ LibreOffice Team 2021-09-17 07:02:53 UTC 
Thinking a bit more about this, we can close this bug.

The undo part is fixed, for the anchor change we have bug 143143