Bug 140246 - Missing context menu icons
Summary: Missing context menu icons
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 157472 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-02-07 18:48 UTC by Petr Valach
Modified: 2023-10-02 09:33 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Missing context menu icons (54.20 KB, image/png)
2021-02-07 18:48 UTC, Petr Valach
Details
Config to force menu icons (670 bytes, application/xml)
2021-02-07 22:03 UTC, Maxim Monastirsky
Details
expert setting (57.29 KB, image/png)
2021-02-07 22:14 UTC, Petr Valach
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Valach 2021-02-07 18:48:27 UTC
Created attachment 169552 [details]
Missing context menu icons

Steps for reproduction:
1. Install LO 7.1.
2. Start any application, for example Writer.
3. Right mouse click anywhere.

Result:
Context menu are missing. They appear in 6.4.7.

Same linux DE (KDE 5), same user folder.


Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 2; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 1 raal 2021-02-07 20:26:15 UTC
confirm with  Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 40b56cd8da8c38582dc4660b486993d1b4711535
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded


Also missing options in Options > LibreOffice > View
Comment 2 raal 2021-02-07 20:39:56 UTC
This seems to have begun at the below commit.
Adding Cc: to Noel Grandin ; Could you possibly take a look at this one?
Thanks

bibisect-linux-64-6.3$ 5bf61ce1eb7304a72c9bdc6562355ea76071d5e2 is the first bad commit
commit 5bf61ce1eb7304a72c9bdc6562355ea76071d5e2
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Mon Apr 29 08:47:23 2019 +0200

    source 9eae555542ce01cb289b9e736454abcf835b8394

commit 9eae555542ce01cb289b9e736454abcf835b8394	[log]
author	Noel Grandin <noel.grandin@collabora.co.uk>	Sun Apr 28 09:54:42 2019 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	Mon Apr 29 08:30:26 2019 +0200
tree 7e6f1d44f609ebcf05e3675ea8f10e41652cc078
parent 8647288180806f8515bf2548db7280cbc657eaf3 [diff]

speed up gtk menu construction at startup
Comment 3 Maxim Monastirsky 2021-02-07 21:21:44 UTC
There is some confusion here. The regression pointed in comment 2 is already fixed (twice) - see Bug 126830. Despite that, menu icons are off by default to follow the GNOME design, and the option to show them was hidden from UI - see Bug 123265 comment 20.

Still, there is a way to activate menu icons via expert config:

1. Tools > Options... > LibreOffice > Advanced > Open Expert Configuration.
2. Search for IsSystemIconsInMenus, and set it to false.
3. Search for ShowIconsInMenues, and set it to true.
4. Confirm and restart LO.
Comment 4 Petr Valach 2021-02-07 21:24:13 UTC
I cannot imagine I would say to our readers - use expert settings because some people feel it's great idea.
Comment 5 Maxim Monastirsky 2021-02-07 22:03:31 UTC
Created attachment 169560 [details]
Config to force menu icons

The attached file can be installed via Tools > Extension Manager, and have the same effect without changing expert configs manually.

Also, given that you use KDE, you might want to just use the KDE LO plugin which doesn't have that restriction, unlike the gtk3 one.
Comment 6 Petr Valach 2021-02-07 22:08:36 UTC
(In reply to Maxim Monastirsky from comment #5)
> Created attachment 169560 [details]
> Config to force menu icons
> 
> The attached file can be installed via Tools > Extension Manager, and have
> the same effect without changing expert configs manually.
> 
> Also, given that you use KDE, you might want to just use the KDE LO plugin
> which doesn't have that restriction, unlike the gtk3 one.

Understand, thank you, but KDE integration pack is unusable for me.
https://bugs.documentfoundation.org/show_bug.cgi?id=140251

I think removing one good feature is simply silly. There is no real reason for that. I accept it but don't understand.
Comment 7 Petr Valach 2021-02-07 22:14:18 UTC
Created attachment 169561 [details]
expert setting

I used expert settings, and still without icons in menu. KDE, without kde-integration pack.
I really don't think this issue is resolved.
Comment 8 Maxim Monastirsky 2021-02-07 22:27:23 UTC
(In reply to Petr Valach from comment #7)
> Created attachment 169561 [details]
> expert setting
IsSystemIconsInMenus needs to be *false*.
Comment 9 Petr Valach 2021-02-07 22:35:23 UTC
(In reply to Maxim Monastirsky from comment #8)
> (In reply to Petr Valach from comment #7)
> > Created attachment 169561 [details]
> > expert setting
> IsSystemIconsInMenus needs to be *false*.

Sorry, my mistake. Now it works. Anyway, for BFU it isn't user friendly and I think user should have option for choice. Not to dictate him how to behave. Just typically Gnome policy in any case.

Thank you for your time and patience. Anyway, I am very curious how readers will react to that issue. The worst thing, it isn't needed. It's just useless freak.
Comment 10 Heiko Tietze 2023-10-02 09:33:43 UTC
*** Bug 157472 has been marked as a duplicate of this bug. ***