Bug 140417 - dragging destination hover-guides painted at wrong places for RTL sheets
Summary: dragging destination hover-guides painted at wrong places for RTL sheets
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 140416 (view as bug list)
Depends on:
Blocks: RTL-UI
  Show dependency treegraph
 
Reported: 2021-02-14 22:04 UTC by Eyal Rozenberg
Modified: 2022-03-16 22:01 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screenshot - while and before dragging the sheet-tab (12.79 KB, image/png)
2021-02-14 22:05 UTC, Eyal Rozenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2021-02-14 22:04:16 UTC
Description:
When you click-and-hold on a tab in the sheet deck in Calc, and move the sheet left or right, LO paints small triangles/arrow-heads on both sides of the boundary between adjacent sheet tabs, where your sheet would be placed if you release the mouse.

However:

1. If your sheet tab deck is in RTL mode (which happens when the current sheet is in RTL direction), the triangles are drawn on the two opposite sides of adjacent sheet tabs. So, in both cases it's on the right side of the earlier tab and the left side of the latter tab, instead of being on the 'end' side and 'start' side respectively. A screenshot will follow.

2. Bits of the triangles are left behind when you move around with your selected tab (without having released the mouse). This is an unrelated bug which you will see manifested in the screenshot, but - please ignore it in the context of this bug.

Steps to Reproduce:
1. Open Calc
2. Add a few more sheets, for a total of, say, 4.
3. Select the fourth sheet in the deck.
4. Ensure the sheet direction is RTL (e.g. using the Sheet menu).
5. Hold down your mouse on the 4th sheet's tab in the tab deck
6. Drag the sheet-tab slowly over the other sheet-tabs in the deck

Actual Results:
Triangles drawn on opposite ends of consecutive sheet-tabs.

Expected Results:
Triangles drawn on adjoining ends of consecutive sheet-tabs.


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested with:

Version: 7.1.0.3 / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 4; OS: Linux 5.9; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US
Calc: threaded

But I believe this has been happening for a while.
Comment 1 Eyal Rozenberg 2021-02-14 22:05:40 UTC
Created attachment 169742 [details]
Screenshot - while and before dragging the sheet-tab

As mentioned before - ignore the fact that some residual junk-pixels appear on the sides of most tabs.
Comment 2 Eyal Rozenberg 2021-02-14 22:18:38 UTC
Correction to my reproduction instructions: In step (4.), you must ensure _all_ sheets are RTL. Otherwise the whole deck is repeatedly repainted, on the left then on the right and back again.
Comment 3 [REDACTED] 2021-02-14 23:05:22 UTC
*** Bug 140416 has been marked as a duplicate of this bug. ***
Comment 4 Xisco Faulí 2021-05-10 16:35:09 UTC
Hello Eyal,
Could you please try to reproduce it with version 7.1.3.2 of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ?
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version.
Comment 5 Eyal Rozenberg 2021-05-10 18:19:40 UTC
(In reply to Xisco Faulí from comment #4)
> Could you please try to reproduce it with version 7.1.3.2 of LibreOffice
> from https://www.libreoffice.org/download/libreoffice-fresh/ ?

Bug still manifests with:

Version: 7.1.3.2 / LibreOffice Community
Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: he-IL (en_IL); UI: en-US
Calc: threaded
Comment 6 AndreasHengst 2022-03-16 20:57:18 UTC
I was able to reproduce the behavior in
Mac OSX - Calc ver 7.1.0.3

and on Windows:
Version: 7.3.0.3 (x64) / LibreOffice Community
Build ID: 0f246aa12d0eee4a0f7adcefbf7c878fc2238db3
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

was able to reproduce in yesterday's
Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: b70d17b08a7f24e4c470831910e63493082e0874
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL

I'm a beginning triage-er so will attempt to find duplicates next. Changing status from UNCONFIRMED to NEW because bug is present in latest code.
Perhaps Importance could be lowered to 'minor'.
-AH
Comment 7 Eyal Rozenberg 2022-03-16 22:01:35 UTC
(In reply to AndreasHengst from comment #6)
> Perhaps Importance could be lowered to 'minor'.

I don't believe the importance field is given all that much, well, importance, by developers. But - if you want to change it, go ahead.