Description: If we do protect and unprotect the sheet two times in a row, it gets displayed as: Unprotect Sheet Protect Sheet Unprotect Sheet Protect Sheet It creates confusion that which password was set in which case. Steps to Reproduce: 1.Click on protect sheet and type a password 2.Click on unprotect sheet 3.Click on protect sheet and type another password 4.Click on unprotect sheet Actual Results: It gets displayed as follows in undo section : Unprotect Sheet Protect Sheet Unprotect Sheet Protect Sheet Expected Results: Should be displayed like Unprotect Sheet : "h***" Protect Sheet : "h***" if the password was set starting from "h" the second time Unprotect Sheet : "m***" Protect Sheet :"m***" if the password was set starting with "m" the first time Reproducible: Always User Profile Reset: No Additional Info: Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 6b15a8658f369e4144251854bcdb736acb595f47 CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: default; VCL: win Locale: en-IN (en_IN); UI: en-US Calc: threaded
Created attachment 169834 [details] Actual results
(In reply to An-Kh from comment #0) > Description: > If we do protect and unprotect the sheet two times in a row, it gets > displayed as: > > Unprotect Sheet > Protect Sheet > Unprotect Sheet > Protect Sheet > > It creates confusion that which password was set in which case. > > > Steps to Reproduce: > 1.Click on protect sheet and type a password > 2.Click on unprotect sheet > 3.Click on protect sheet and type another password > 4.Click on unprotect sheet > > Actual Results: > It gets displayed as follows in undo section : > > Unprotect Sheet > Protect Sheet > Unprotect Sheet > Protect Sheet > > Expected Results: > Should be displayed like > > Unprotect Sheet : "h***" > Protect Sheet : "h***" if the password was set starting from "h" the > second time > Unprotect Sheet : "m***" > Protect Sheet :"m***" if the password was set starting with "m" the first > time > > > Reproducible: Always > > > User Profile Reset: No > > > > Additional Info: > Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community > Build ID: 6b15a8658f369e4144251854bcdb736acb595f47 > CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: default; VCL: win > Locale: en-IN (en_IN); UI: en-US > Calc: threaded Similar results can be seen for spreadsheet structure protection
I don't like it, but let's ask UX-team
Also, if two different sheets are used and different passwords are set to them, I think the output should be like Unprotect Sheet2 Protect Sheet2 Unprotect Sheet1 Protect Sheet1
The topic was on the agenda for the design meeting but has not attract interest. I see privacy issues with the exposure of the password (even partially) and doubt the usefulness since you cannot pick one command from the undo stack. You always go back step by step - and what happens is transparently shown. => WF
(In reply to Heiko Tietze from comment #5) > The topic was on the agenda for the design meeting but has not attract > interest. > > I see privacy issues with the exposure of the password (even partially) and > doubt the usefulness since you cannot pick one command from the undo stack. > You always go back step by step - and what happens is transparently shown. > => WF Hi I completely agree.. There can be privacy issues.. Could you please have a look at comment 4 as well? I think the feature discussed in comment 4 is a valid one :)
(In reply to An-Kh from comment #4) > Also, if two different sheets are used and different passwords are set to > them, I think the output should be like > > Unprotect Sheet2 > Protect Sheet2 > Unprotect Sheet1 > Protect Sheet1 Adding the sheet name to the undo/redo list does not harm privacy but has little benefit IMHO since aou get feedback from the lock symbol. But OTOH it might be difficult to figure where this happens for a large number of sheets. So no objection.