Created attachment 169971 [details] File that makes Draw crash This bug was filed from the crash reporting server and is br-fca88dae-1526-4962-80a6-a8c8249d6e8c. ========================================= I am trying to export the attached ODG file (created from two scanned PDF files) as a 2-page PDF file. However, it reliably crashes on my (very old: 2007) machine. To reproduce: open the attached ODG, File > Export as > Export directly as PDF, select a destination file, Save. If I do File > Export as > Export as PDF and let everything by default, except check Lossless compression and disable Reduce image resolution, it does the same. In safe mode, it's the same. I installed LibreOffice today, there are no addins. Version of LibreOffice: https://git.libreoffice.org/core/+log/f6099ecf3d29644b5008cc8f48f42f4a40986e4c Version of Windows: 10 1909, build 18363.13679, x64 (no update available) Machine: Intel Core 2 Duo E6750, 4 GB of RAM
After a few Windows updates, I still get the same crash, but the trace seems different: https://crashreport.libreoffice.org/stats/crash_details/8b3bd0c0-4b87-49b1-8d55-26bcbff09c5e
Reproduced in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 43e306ebe61ef5a849dcfd1e74b697be3b3fe716 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=c724c1bec549f224656e7ca3290494159dda7e26 author Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> 2020-10-28 13:55:23 +0100 committer Tomaž Vajngerl <quikee@gmail.com> 2020-11-02 20:11:03 +0100 commit c724c1bec549f224656e7ca3290494159dda7e26 (patch) tree 0447dfeba6192a3e021d3f04355e5060e7d13c12 parent be1eeabaae38f4890a55cd206f22b03818253fb6 (diff) pdf: deduplicate resources when copying from external PDF stream Bisected with: bibisect-linux64-7.1 Adding Cc: to Tomaž Vajngerl
Hm.. PDF file has an unexpected null character in the stream, which causes the crash because the document can't be correctly read. I have fixed the export so a bad PDF doesn't crash LibreOffice and made the parser more lenient to ignore a null character and tries to continue.
Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2c1ed5a5dad827cde032f27a4348e81be15889bc tdf#140606 make PDF parsing more lenient and prevent a crash It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 0b072e279f5f775a4cd64d9b1275e5ab17d50f05 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Tomaž Vajngerl, thanks for fixing this issue. Should it be closed as RESOLVED FIXED ?
Tomaž Vajngerl committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/ed7a3dabc8c35b8b33bad33fc26ebd8fb80b0cbd tdf#140606 make PDF parsing more lenient and prevent a crash It will be available in 7.1.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.