Bug 140674 - EDITING Autocorrect no longer works with Change Tracking enabled
Summary: EDITING Autocorrect no longer works with Change Tracking enabled
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0 target:7.1.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2021-02-26 07:21 UTC by NISZ LibreOffice Team
Modified: 2021-03-10 11:06 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer (8.87 KB, application/vnd.oasis.opendocument.text)
2021-02-26 07:21 UTC, NISZ LibreOffice Team
Details
Screenshot of the problem in Writer (22.55 KB, image/png)
2021-02-26 07:22 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-02-26 07:21:41 UTC
Created attachment 170066 [details]
Example file from Writer

As noticed in: https://bugs.documentfoundation.org/show_bug.cgi?id=83419#c15
Autocorrect does not replace presets starting with : (like emoji) when change tracking is enabled.

Steps to reproduce:
1. File> New> Text document
2. type :--: 
3. Enable change tracking and type :--: again

Actual results:
:--: replaced by – wihtout change tracking.

Expected results:
No replacement happens with change tracking enabled.

LibreOffice details:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: af64bc49d872d8a040d66387303def98eae5cd51
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-GB
Calc: CL

Additional Information: 
Bibisected using bibisect-win64-7.1 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2951c96bcb673a260a09e2c6eb92ca0f99bf0c18
author	László Németh <nemeth@numbertext.org>	Mon Nov 09 11:36:57 2020 +0100
committer	László Németh <nemeth@numbertext.org>	Mon Nov 09 15:59:00 2020 +0100

tdf#83419 sw change tracking: clean-up autocorrect

Adding CC to: László Németh
Comment 1 NISZ LibreOffice Team 2021-02-26 07:22:01 UTC
Created attachment 170067 [details]
Screenshot of the problem in Writer
Comment 2 Commit Notification 2021-03-09 16:43:01 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/db999ddee7a890390f66d7e34906066c8bf178da

tdf#140674 sw change tracking: fix :emoji: replacement

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2021-03-10 11:06:14 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/fa90d6da27a56cd2002aabb5f026d39b852f1160

tdf#140674 sw change tracking: fix :emoji: replacement

It will be available in 7.1.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.