Bug 140709 - Undo of image position change doesn't restore original of an different image
Summary: Undo of image position change doesn't restore original of an different image
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Writer-Images Undo-Redo
  Show dependency tree / graph
 
Reported: 2021-02-28 08:55 UTC by Telesto
Modified: 2022-06-12 02:07 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (166.47 KB, application/vnd.oasis.opendocument.text)
2021-02-28 08:55 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-02-28 08:55:25 UTC 
Description:
Undo of image position change doesn't restore original of an different image

Steps to Reproduce:
1. Open the attached file
2. Select top left image (containing STI)
3. Press arrow left -> Image below jumps off page
4. Press CTRL+Z

Actual Results:
Image move to next page isn't undone

Expected Results:
Should be so


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
7.2

and in
Version: 6.2.4.0.0+
Build ID: 5c5eab3522368d6baa7ab6ef1b6c9f5eaaab4fad
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Telesto 2021-02-28 08:55:40 UTC 
Created attachment 170123 [details]
Example file
Comment 2 Telesto 2021-02-28 09:01:15 UTC 
And in
Version: 5.4.0.3
Build ID: 7556cbc6811c9d992f4064ab9287069087d7f62c
CPU threads: 4; OS: Windows 6.2; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL

and in
Version: 5.2.5.0.0+
Build ID: a4d4fbeb623013f6377b30711ceedb38ea4b49f8
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-2, Time: 2016-12-24_14:43:55
Locale: nl-NL (nl_NL); Calc: group

and in
Version: 5.1.0.3
Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737
CPU Threads: 4; OS Version: Windows 6.2; UI Render: default; 
Locale: en-US (nl_NL)

not in (image overlapping footer; so no jump)
Versie: 5.0.6.3 (x64)
Build ID: 490fc03b25318460cfc54456516ea2519c11d1aa
Locale: nl-NL (nl_NL)

Adding bibisectrequest.. I think the undo aspect has been overlooked..
Comment 3 Dieter 2021-03-15 07:49:53 UTC 
I confirmm it with

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 21c602913d98ef46b49fc9b6f9071db92a1597c6
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL

Same result, if you press arrow right instead of undo. Second image jumps to the second page, because first paragraph has an additional line after steps 3
Comment 4 Aron Budea 2022-06-12 02:07:00 UTC 
The described problem isn't a regression, if you perform the following steps, the bug can already be reproduced in 3.3.0:
1. Open the attached file
2. Select top left image (containing STI)
3. Enlarge image so it pushes the image at the bottom to the next page
4. Press CTRL+Z

Nevertheless the image jumping to the next page after pressing arrow left started with the following commit in 5.1, bibisected using repo bibisect-win32-5.1:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=20538f233fe120b33a23d594458d4639b0c9670e
author		Tobias Lippert <drtl@fastmail.fm>	2015-09-27 21:30:20 +0200
committer	Oliver Specht <oliver.specht@cib.de>	2015-11-04 14:30:17 +0000

tdf#83910 Formatting of lines which consist of a single dummy line only