Bug 140936 - RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type
Summary: RFE: Writer: Change Selection type icon in Statusbar to labels depending on c...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Jim Raykowski
URL:
Whiteboard: target:7.2.0
Keywords:
: 88477 140789 (view as bug list)
Depends on:
Blocks: Statusbar
  Show dependency treegraph
 
Reported: 2021-03-10 14:48 UTC by Roman Kuznetsov
Modified: 2024-02-10 02:18 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
statusbar section mode control demo (897.77 KB, video/x-matroska)
2021-03-11 20:39 UTC, Jim Raykowski
Details
selection mode control with different image for each mode (258.80 KB, video/x-matroska)
2021-03-13 05:10 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2021-03-10 14:48:46 UTC
Description:
RFE: Writer: Change Selection type icon in Statusbar to labels depending on current type

Steps to Reproduce:
1. Open Writer document
2. Look at Statusbar on Selection type icon
3. You can't know which type is active now

I suggest change the icon to labels (Standard, Extending, Adding, Dlock) depending on current type

Actual Results:
User can easy only one icon for all selection types and he can't see which fron it is active right now

Expected Results:
User can easy see which selection type is active right now


Reproducible: Always


User Profile Reset: No



Additional Info:
-
Comment 1 Jim Raykowski 2021-03-11 20:39:17 UTC
Created attachment 170416 [details]
statusbar section mode control demo

Pending UX approval:

https://gerrit.libreoffice.org/c/core/+/112367
Comment 2 V Stuart Foote 2021-03-11 21:00:57 UTC
Roman, *

Jim as usual hits the request, but is the UI best served by adding textual labeling to the Status bar? 

The labeling, especially whe translated, is going to suck up a lot of horizontal width on the Status bar--which is always space constrained.

The meaning of the current multi-mode selection Icon is functional--but better is concise.  And, we can determine mode with mouse-over tool-tip, or change with r-mouse context menu.

If we are to make any visual change--we'd be better served with a set of icons for the modes (but difficult to capture iconography for use on the Status bar as these are minimal size icons).

All that said, I don't think this is the best way to adjust things.

Stuart

=-ref-=
Help for the modes is here:
https://help.libreoffice.org/7.2/en-US/text/shared/02/20050000.html?DbPAR=SHARED#bm_id3148668
Comment 3 Roman Kuznetsov 2021-03-11 21:11:42 UTC
In writer we have a free space in statusbar enough.
Comment 4 Roman Kuznetsov 2021-03-11 21:19:57 UTC
(In reply to Jim Raykowski from comment #1)
> Created attachment 170416 [details]
> statusbar section mode control demo
> 
> Pending UX approval:
> 
> https://gerrit.libreoffice.org/c/core/+/112367

Jim, thanks for a nice proposal. I would delete a word "selection" from labels in statusbar. Let's it will be just words "Standard", "Extending", "Adding" and "Block" as I wrote in description. With it we save some horizontal space as want V Stuart Foote
Comment 5 Jim Raykowski 2021-03-11 21:36:26 UTC
(In reply to Roman Kuznetsov from comment #4)
> > https://gerrit.libreoffice.org/c/core/+/112367
> 
> Jim, thanks for a nice proposal. I would delete a word "selection" from
> labels in statusbar. Let's it will be just words "Standard", "Extending",
> "Adding" and "Block" as I wrote in description. With it we save some
> horizontal space as want V Stuart Foote
Done in patch set 2
Comment 6 Heiko Tietze 2021-03-12 09:06:21 UTC
Agree with Stuart, different icons should do the trick. Label would be required for Benjamin but he is not the target of this function. And when Eve intentionally changes the selection mode she knows what she does. The label is fine for the tooltip.
Comment 7 Mike Kaganski 2021-03-12 09:10:13 UTC
(In reply to Roman Kuznetsov from comment #3)
> In writer we have a free space in statusbar enough.

Note that "enough" depends on "writer window is expanded to whole screen" (or the like). Consider also "two windows (one of them Writer's) side by side".
Comment 8 Roman Kuznetsov 2021-03-12 09:47:08 UTC
(In reply to Heiko Tietze from comment #6)
> Agree with Stuart, different icons should do the trick. Label would be
> required for Benjamin but he is not the target of this function. And when
> Eve intentionally changes the selection mode she knows what she does. The
> label is fine for the tooltip.

You forgot about too small height of the statusbar. Any icons there will be too small that people can see difference between its
Comment 9 Roman Kuznetsov 2021-03-12 09:50:22 UTC
(In reply to Jim Raykowski from comment #5)
> (In reply to Roman Kuznetsov from comment #4)
> > > https://gerrit.libreoffice.org/c/core/+/112367
> > 
> > Jim, thanks for a nice proposal. I would delete a word "selection" from
> > labels in statusbar. Let's it will be just words "Standard", "Extending",
> > "Adding" and "Block" as I wrote in description. With it we save some
> > horizontal space as want V Stuart Foote
> Done in patch set 2

Jim, can you test Writer with your patch for 1024 px LO's window by width (it's a recomended minimum size for LibreOffice)? Will all statusbar's items available for user?
Comment 10 Mike Kaganski 2021-03-12 10:18:57 UTC
Note also that availability of space depends on length of text in elements. E.g., "words + characters" section will expand as soon as you select something, and become "Selected: 233 words, 1.615 characters"; text language may have not only short entries like "Russian", but also longer ones, like "English (New Zealand)", etc.

I found out that when space is not enough, we hide text language first, and keep this selection mode, which looks strange given relative importance of these elements (people often need to know the language of the text they input, to have it spell-checked properly, while selection mode is used less often).

Also note that in applications that use textual labels with lots of such data (AutoCAD), the test is abbreviated, and this is targeted at engineers, i.e. people with technical set of mind ... I doubt this is suitable for Writer.
Comment 11 Jim Raykowski 2021-03-13 05:10:52 UTC
Created attachment 170450 [details]
selection mode control with different image for each mode

Here is a go at using a different image for each selection mode. The images are for demonstration purpose. Hoping the LO icon design talents can help with these.
Comment 12 Roman Kuznetsov 2021-03-13 12:28:38 UTC
Rizal, we need your help with icons =) I suggest to add a letter to icons : S, E, A, B, instead mini pictograms 

Jim, if we are going with icons, then I ask you delete left click action or change it action to show a context menu.
Comment 13 Jim Raykowski 2021-03-13 21:55:01 UTC
(In reply to Roman Kuznetsov from comment #12)
> Jim, if we are going with icons, then I ask you delete left click action or
> change it action to show a context menu.

done in patch set 4
Comment 14 Rizal Muttaqin 2021-03-13 22:58:18 UTC
(In reply to Roman Kuznetsov from comment #12)
> Rizal, we need your help with icons =) I suggest to add a letter to icons :
> S, E, A, B, instead mini pictograms 
> 
Sure I can give hand, but should we go with Anglo-Saxonism again after all B,I,U saga?
Comment 15 Heiko Tietze 2021-03-15 09:38:41 UTC
(In reply to Rizal Muttaqin from comment #14)
> Sure I can give hand, but should we go with Anglo-Saxonism again after all
> B,I,U saga?

Nope, text in icons is never a good idea. I'm sure you are creative enough to draw distinguishable icons and, again advertising for tooltips, the user can always get more information.
Comment 16 Jim Raykowski 2021-03-20 19:40:23 UTC
*** Bug 140789 has been marked as a duplicate of this bug. ***
Comment 17 Rizal Muttaqin 2021-03-27 03:47:37 UTC
(In reply to V Stuart Foote from comment #2)
> Roman, *
> 
> 
> =-ref-=
> Help for the modes is here:
> https://help.libreoffice.org/7.2/en-US/text/shared/02/20050000.
> html?DbPAR=SHARED#bm_id3148668

Can someone give me any screencast on how each selection mode works? Would be nice if the recorder use keystroke app so I can see what's he clicked on the keyboard. I don't understand how especially Adding selection (Shift+F8) and Block selection (Ctrl+Shift+F8) work.
Comment 18 V Stuart Foote 2021-03-27 05:09:21 UTC
(In reply to Rizal Muttaqin from comment #17)

> Can someone give me any screencast on how each selection mode works? Would
> be nice if the recorder use keystroke app so I can see what's he clicked on
> the keyboard. I don't understand how especially Adding selection (Shift+F8)
> and Block selection (Ctrl+Shift+F8) work.

Didn't Jim do that with the first attachment 170416 [details]?

But the help description is pretty precise...

https://help.libreoffice.org/7.2/en-US/text/shared/02/20050000.html?DbPAR=SHARED#bm_id3148668
Comment 19 Rizal Muttaqin 2021-03-27 05:26:13 UTC
(In reply to V Stuart Foote from comment #18)
> Didn't Jim do that with the first attachment 170416 [details]?
> 
Ah thank you, but the attachment does not show how to achieve same result by using keyboard? OK but the video is enough for projecting the icon appearance.
Comment 20 Commit Notification 2021-03-27 08:02:38 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e18b743a840475cfbdfba437a1edf8677a5f93bd

tdf#140936 statusbar selection mode control improvements

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Jim Raykowski 2021-03-27 19:30:21 UTC
Thanks Rizal for making the icons and incorporating them into the patch.
Comment 22 Stéphane Guillou (stragu) 2021-11-30 13:15:05 UTC
Verified as fixed in:

Version: 7.2.0.2 / LibreOffice Community
Build ID: 614be4f5c67816389257027dc5e56c801a547089
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 23 Jim Raykowski 2024-02-10 02:18:17 UTC
*** Bug 88477 has been marked as a duplicate of this bug. ***