Bug 141012 - Password to the associated DB asked again twice after cancelled first time, when opening More Fields dialog in a MailMerge document
Summary: Password to the associated DB asked again twice after cancelled first time, w...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.1.2 release
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.2.0 target:7.1.3
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-14 08:20 UTC by Mike Kaganski
Modified: 2021-05-18 08:38 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2021-03-14 08:20:51 UTC
If the database associated with this MailMerge document is password-protected, then opening More Fields dialog requests that password, and after the request is cancelled, *it is asked again twice*.

Steps:

1. Use steps from tdf#141011.
2. After the password is requested, cancel it.
=> Password request is shown again.

Happens after https://git.libreoffice.org/core/commit/647c9de0338350c1b5eff4b9adf08bd06930e36b; but this is not a true regression. The commit must not be reverted.
Comment 1 Mike Kaganski 2021-03-14 08:36:14 UTC
See screen cast in attachment 170471 [details] from bug 141011.
Comment 2 Mike Kaganski 2021-03-14 11:51:03 UTC
https://gerrit.libreoffice.org/c/core/+/112467
Comment 3 Commit Notification 2021-03-14 12:58:44 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/351edb44eb0548f7e56464de42c1758a1f5e4ab4

tdf#141012: do not try to expand the node if RequestingChildrenHdl failed

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2021-03-17 18:35:07 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/69ff121dbee216ed2e4d47207db1d3715bbe0f85

tdf#141012: do not try to expand the node if RequestingChildrenHdl failed

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.