Bug 141297 - Removing links for external images doesn't work
Summary: Removing links for external images doesn't work
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0 target:7.1.3 target:7.0.6
Keywords: bibisected, bisected, regression
: 127474 141601 (view as bug list)
Depends on:
Blocks: Regressions-imageHandling
  Show dependency treegraph
 
Reported: 2021-03-28 10:26 UTC by Arnaud Versini
Modified: 2021-07-17 19:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Arnaud Versini 2021-03-28 10:26:00 UTC
Description:
We can't remove links to external images and insert them in the odp file

Steps to Reproduce:
1.Create a presentation
2.Insert an image linked and save the document
3.Reopen the presentation and remove the link to the image

Actual Results:
The image is still linked

Expected Results:
The image should be in the document


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: c7483d48df1b9ae70335346846d02a4fc53b4558
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: CL
Comment 1 Arnaud Versini 2021-03-28 10:27:50 UTC
Same in Version: 7.1.1.2 / LibreOffice Community
Build ID: 10(Build:2)
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Calc: threaded
Comment 2 Regis Perdreau 2021-03-29 11:06:18 UTC
Confirmed in Version: 7.1.1.2 (x64) / LibreOffice Community
Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676
CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: fr-FR (fr_FR); UI: fr-FR
Calc: threaded

Disconnect link to an external image with menu "edit->edit link to external files" option seems not work...
The link is kept at the next document load.
Comment 3 Arnaud Versini 2021-04-04 09:58:37 UTC
Working on Version: 6.0.0.3
Build ID: 64a0f66915f38c6217de274f0aa8e15618924765
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk2; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group
Comment 4 Arnaud Versini 2021-04-04 10:04:29 UTC
Not working in 
Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: gtk2; 
Locale: fr-FR (fr_FR.UTF-8); Calc: group threaded
Comment 5 Arnaud Versini 2021-04-04 15:55:56 UTC
No problem in writer
Comment 6 Arnaud Versini 2021-04-05 12:06:56 UTC
This patch seems to remove the issue, but I don't like it !
https://gerrit.libreoffice.org/c/core/+/113597
Comment 7 Commit Notification 2021-04-06 13:25:07 UTC
Arnaud Versini committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/7289b9a90f5f8349875856c552330d512004925e

tdf#141297 : remove link to the file

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2021-04-06 13:40:23 UTC
*** Bug 127474 has been marked as a duplicate of this bug. ***
Comment 9 Xisco Faulí 2021-04-06 13:41:10 UTC
This is a regression from

author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2018-04-13 16:58:49 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2018-04-16 02:52:02 +0200
commit 9fb7aaf570c03c8a26d763f1205fb8c890e8211a (patch)
tree 8f4466b24d9fcae2da5043479a57fabc662a2c43
parent ba69036c8e889237da4bb312d7c5c94066abbfd3 (diff)
Make linked graphic register into LinkedManager again
Comment 10 Commit Notification 2021-04-06 19:17:40 UTC
Arnaud Versini committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/6494b99f09a29c22d51fb898423ced36ce02a9e7

tdf#141297 : remove link to the file

It will be available in 7.1.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-04-07 06:54:55 UTC
Arnaud Versini committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/b4e6c12dec3ddb2d6e78f136230f24feffe73d58

tdf#141297 : remove link to the file

It will be available in 7.0.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2021-04-07 07:50:39 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/795a3ad8efa8b418f3c6477379c13560c3b4b890

tdf#141297: sd: Add UItest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Xisco Faulí 2021-04-08 08:50:21 UTC
Verified in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 78eaf6489a6542378ffab7eef39ec0a2c5f1a10a
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Arnaud Versini, thanks for fixing this issue. Closing as VERIFIED FIXED!!
Comment 14 Arnaud Versini 2021-04-11 09:36:40 UTC
*** Bug 141601 has been marked as a duplicate of this bug. ***