Bug 141301 - extrusion-skew angle value -135 is not written to file, although it is not the default value
Summary: extrusion-skew angle value -135 is not written to file, although it is not th...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0 target:7.2.3
Keywords:
Depends on:
Blocks: Shapes-Custom
  Show dependency treegraph
 
Reported: 2021-03-28 12:58 UTC by Regina Henschel
Modified: 2023-05-26 18:06 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2021-03-28 12:58:08 UTC
Start Impress. Insert a custom shape, e.g. a rectangle from "Basic shapes" floater. Toggle it to extrusion mode. Do not touch the Directions floater in the toolbar. Save the document.

Examine the file. It should have an attribute draw:extrusion-skew="50 -135". The default value for this attribute is "50 45", so "50 -135" may not be omitted. But the attribute is missing.

Open the file in PowerPoint. It correctly shows the extrusion with skew angle 45 because of the missing attribute.

The error was introduced in OOo, although already standard ODF 1.1 has "50 45" as default value.
Comment 1 Julien Nabet 2021-03-28 16:25:34 UTC
I gave a first try with https://gerrit.libreoffice.org/c/core/+/113257 (perhaps too naive?)
Comment 2 Regina Henschel 2021-03-28 23:17:12 UTC
(In reply to Julien Nabet from comment #1)
> I gave a first try with https://gerrit.libreoffice.org/c/core/+/113257
> (perhaps too naive?)

That could be at least a solution for LO7.1, because changing the internal handling from default -135 to 45 will surely not happen in 7.1.

The comment should state, that LO 7.1 (wrongly) treats internally the value -135 as default value, but that it is not default value in ODF and therefore has to written out.

If we take this too for LO 7.2, a warning is needed, that this has to be removed in case the internal handling of default value will be changed from -135 to 45.

I think a decision is needed, whether the internal default should be changed at all. A similar problem with writing out the correct value will occur, when we start to export custom shape extrusion to OOXML. [Currently I'm working on the import from OOXML.]
Comment 3 Julien Nabet 2021-03-29 15:03:49 UTC
(In reply to Regina Henschel from comment #2)
> ...
> 
> I think a decision is needed, whether the internal default should be changed
> at all. A similar problem with writing out the correct value will occur,
> when we start to export custom shape extrusion to OOXML. [Currently I'm
> working on the import from OOXML.]

Thank you for your detailed feedback,  I thought it would have been simpler, I'm not sure to understand so prefer letting this to experts ; I was indeed a bit too naive! :-) I gave up the patch. => uncc myself.
Comment 4 Xisco Faulí 2021-04-30 09:49:29 UTC
Moving to NEW
Comment 5 Regina Henschel 2021-10-25 17:47:07 UTC
@Julian: Please reopen https://gerrit.libreoffice.org/c/core/+/113257.

I have thought about it some time now and think, we should go that way and do not change the internal default value.
Comment 6 Commit Notification 2021-10-28 12:16:24 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/773465fb95c1be48f8fdf406d2d39caa142050db

tdf#141301: extrusion-skew angle value -135 is not written to file...

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2021-11-01 11:16:05 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/0ec2f94100cf1b8c24642e79e60810a79ff075c3

tdf#141301: extrusion-skew angle value -135 is not written to file...

It will be available in 7.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.