Bug 141676 - OPTIONS DIALOG: Change command label for "Add Paragraph and Table spacing at tops of pages"
Summary: OPTIONS DIALOG: Change command label for "Add Paragraph and Table spacing at ...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: sdc.blanco
URL:
Whiteboard: target:24.2.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Options-Dialog-Writer
  Show dependency treegraph
 
Reported: 2021-04-13 12:39 UTC by R. Green
Modified: 2023-11-05 12:26 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description R. Green 2021-04-13 12:39:38 UTC
Version: 7.0.0.3 (x64)
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

There is an option entitled "Add Paragraph and Table spacing at tops of pages" (Options > LibreOffice Writer > Compatibility).

The problem is that, in my experience, paragraph spacing should always be ignored at the top of a page, but "Above" Table spacing should not.

As a result any table that appears at the top of a page is too near the header. This is especially apparent if you use underlined headers – which is very common.

Suggestion: In Options > LibreOffice Writer > Compatibility, make "Add Paragraph and Table spacing at tops of pages" into two SEPARATE options. i.e.

     Add Paragraph spacing at tops of pages.
     Add Table spacing at tops of pages.
Comment 1 Dieter 2021-04-28 04:49:19 UTC
Rarding to https://help.libreoffice.org/7.2/en-GB/text/shared/optionen/01041000.html?System=WIN&DbPAR=WRITER&HID=modules/swriter/ui/optcompatpage/OptCompatPage#bm_id2023987 this setting is onl valid for the first page of a document? If this is true, this fact should be mentioned in the dialog
Comment 2 Heiko Tietze 2021-04-28 08:27:55 UTC
Miklos, any insights to this compatibility flag?
Comment 3 Miklos Vajna 2021-04-28 11:10:36 UTC
https://api.libreoffice.org/docs/idl/ref/servicecom_1_1sun_1_1star_1_1text_1_1DocumentSettings.html#a8490730058f35cd43883b2ffe2499c58 confirms that this affects the first page only, looks like this is some weird staroffice6 compat setting, both Writer and Word has it on by default for new documents.

So yes, improving the UI string to say this would make sense, I think.
Comment 4 Heiko Tietze 2021-05-04 17:16:55 UTC
So "Add Paragraph and Table spacing at top of the first page" would be the correct label?
Comment 5 Heiko Tietze 2022-03-18 09:27:53 UTC
Let's clarify the wording but keep the options as it is. 

Code pointer:
sw/uiconfig/swriter/ui/optcompatpage.ui

(officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs also talks about pages in general)
Comment 6 sdc.blanco 2023-08-30 09:53:23 UTC
https://gerrit.libreoffice.org/c/core/+/156220
Comment 7 Regina Henschel 2023-08-30 10:13:14 UTC
It is not only for first page, but after each page break.
Comment 8 sdc.blanco 2023-08-30 10:17:04 UTC
(In reply to Regina Henschel from comment #7)
> It is not only for first page, but after each page break.
Thanks Regina.  This point is also noted in the help page.
So....how about...

    Add paragraph and table spacing at top of first page and page breaks

(fwiw, there are longer option labels in this dialog).
Comment 9 Commit Notification 2023-09-06 09:03:28 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/645852b418b759e6576848385b782db6031b9ebc

tdf#141676  make command label more precise

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2023-09-06 10:02:42 UTC
Seth Chaiklin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/eaf5a5d10f601c9943851b79aa5c784c00eedd84

tdf#141676 change in command name
Comment 11 sdc.blanco 2023-09-06 10:03:38 UTC
No further comment received in relation to comment 8, so that version was pushed, and help page updated. Closing this ticket as FIXED.  Further small adjustments, if needed, can be sent here.
Comment 12 Dieter 2023-11-05 12:26:21 UTC
VERIFIED with

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: c0c8cffd3541e3cd616c96791b04e7ebf2b2ed03
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Seth, thanks for fixing it!