Bug 141719 - No KeyID for Title and Content in Slide Properties
Summary: No KeyID for Title and Content in Slide Properties
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
7.1.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-17 02:21 UTC by Rizal Muttaqin
Modified: 2021-04-19 17:20 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot gen rendering (38.33 KB, image/png)
2021-04-17 21:14 UTC, Julien Nabet
Details
screenshot gtk3 rendering (40.73 KB, image/png)
2021-04-17 21:15 UTC, Julien Nabet
Details
Screenshot of an example file in PP and LO nightly (215.45 KB, image/png)
2021-04-19 08:19 UTC, NISZ LibreOffice Team
Details
Simple PPTX with customized slide name (33.67 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2021-04-19 08:20 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rizal Muttaqin 2021-04-17 02:21:19 UTC
"Title and Content" string has no KeyID

Created attachment 170127 [details]
Sample slides in PPTX format

Step to reproduce:

1. Set languang to KeyID (Tools > Options > Language Settings > Languages, select KeyID in User Interface). To enable KeyID, install <package_name>_langpack_qtz.tar.gz from Daily Build (https://dev-builds.libreoffice.org/daily)
2. Open the attachment (from tdf#140714)
3. Go to Sidebar select Properties > Slide. In the Master Slide you can see "Title and Content" without KeyID

Version: gR8uu‖%ABOUTBOXPRODUCTVERSION%ABOUTBOXPRODUCTVERSIONSUFFIX / LibreOffice Community
Build ID: 77419c6f3aba1fd5b1660795923c22a39bdb1bad
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: id-ID (id_ID.UTF-8); UI: qtz
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-04-14_02:39:26
Calc: threaded
Comment 1 Julien Nabet 2021-04-17 07:48:03 UTC
On pc Debian x86-64 with master sources updated today, I can confirm this.
It's not the only element, there are also:
- "Master Background"
- "Master Objects"
- "Master View"
- "Insert Image..."
- "Landscape" + "Portrait"
- "Format:"
- "Orientation:"
- "Background:"

I'd like to know how to pinpoint the pb and how to fix this.
Comment 2 Ming Hua 2021-04-17 17:58:00 UTC
(In reply to Rizal Muttaqin from comment #0)
> 3. Go to Sidebar select Properties > Slide. In the Master Slide you can see
> "Title and Content" without KeyID
I can confirm that this string is not localizable for 7.1.1 on Windows 10:
Version: 7.1.1.2 (x64) / LibreOffice Community
Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: zh-CN (zh_CN); UI: zh-CN
Calc: threaded

(In reply to Julien Nabet from comment #1)
> On pc Debian x86-64 with master sources updated today, I can confirm this.
> It's not the only element, there are also:
> - "Master Background"
> - "Master Objects"
> - "Master View"
> - "Insert Image..."
> - "Landscape" + "Portrait"
> - "Format:"
> - "Orientation:"
> - "Background:"
...but can not confirm these.  They are properly translated in 7.1.1, and in a (admittedly old) 7.2 daily build they have keyIDs:
Version: gR8uu‖%ABOUTBOXPRODUCTVERSION%ABOUTBOXPRODUCTVERSIONSUFFIX (x64) / LibreOffice Community
Build ID: 722ec600e85cca2e94e82e69f8d13773061172b9
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: qtz
Calc: threaded
Comment 3 Ming Hua 2021-04-17 18:17:38 UTC
(In reply to Julien Nabet from comment #1)
> I'd like to know how to pinpoint the pb and how to fix this.
I poked around but didn't find anything definite.  Searching the string "Title and Content" on OpenGrok comes up empty.  The closest I got is:

https://opengrok.libreoffice.org/xref/core/sd/source/filter/ppt/pptin.cxx?r=1d277380#647

...where STR_LAYOUT_DEFAULT_NAME is "Default", defined in sd/inc/strings.hrc .
Comment 4 Rizal Muttaqin 2021-04-17 21:00:34 UTC
(In reply to Julien Nabet from comment #1)
> It's not the only element, there are also:
> - "Master Background"
> - "Master Objects"
> - "Master View"
> - "Insert Image..."
> - "Landscape" + "Portrait"
> - "Format:"
> - "Orientation:"
> - "Background:"
> 

I can not reproduce this. Every string has its own KeyID here
Comment 5 Julien Nabet 2021-04-17 21:14:39 UTC
Created attachment 171261 [details]
screenshot gen rendering

Indeed with gen rendering, I only have "Title and Content" which has no keyid.
Comment 6 Julien Nabet 2021-04-17 21:15:09 UTC
Created attachment 171262 [details]
screenshot gtk3 rendering

Here's the screenshot with gtk3 rendering
Comment 7 Julien Nabet 2021-04-17 21:18:29 UTC
Caolán: some keyid translations don't appear with gtk3 but appear with gen rendering (see screenshots attached), thought you might be interested in this one since it seems specific to gtk3.

I don't forget the main bug here is missing keyid "Title and Content", should I submit a new bugtracker or could it be "Related tdf#141719"? My goal isn't to hijack this bugtracker.
Comment 8 NISZ LibreOffice Team 2021-04-19 08:19:36 UTC
Created attachment 171279 [details]
Screenshot of an example file in PP and LO nightly

Here we see the layout name that can be set in PP under View - Master Slide.
While impress does not exactly import slide layouts from PPTX files, the applied ones are imported merged with their master slide. 
The master slide gets the name of the layout.

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: a809b2ab2553e946431699d9d7ac3f6209cbdd6b
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 9 NISZ LibreOffice Team 2021-04-19 08:20:45 UTC
Created attachment 171280 [details]
Simple PPTX with customized slide name

I think this is NAB, we just see customizable content from the files.
Comment 10 Caolán McNamara 2021-04-19 12:31:00 UTC
(In reply to Julien Nabet from comment #7)
> Caolán: some keyid translations don't appear with gtk3 but appear with gen
> rendering (see screenshots attached), thought you might be interested in
> this one since it seems specific to gtk3.

the keyid language "qtz" isn't a true translation target with real .mo files, but a pseudo-one implemented in unotools/source/i18n/resmgr.cxx:213, the "if it's a key id locale, generate it here" hunk that intercepts attempts to use the .mo file and return the keyid instead. But gtk uses the .mo files directly to extract translations, so in keyid mode the native gtk components continue to work on the .mos as normal. I can't think of a practical way to the native gtk widgets to show keyid.

Which I suppose is an aside from the original bug which does appear to be NAB, e.g. unzipping clippingimagestyles.pptx gives ppt/slideLayouts/slideLayout2.xml which has <p:cSld name="Title and Content"> in the document itself
Comment 11 Julien Nabet 2021-04-19 17:20:38 UTC
(In reply to Caolán McNamara from comment #10)
> (In reply to Julien Nabet from comment #7)
> ...
> the keyid language "qtz" isn't a true translation target with real .mo
> files, but a pseudo-one implemented in unotools/source/i18n/resmgr.cxx:213,
> the "if it's a key id locale, generate it here" hunk that intercepts
> attempts to use the .mo file and return the keyid instead. But gtk uses the
> .mo files directly to extract translations, so in keyid mode the native gtk
> components continue to work on the .mos as normal. I can't think of a
> practical way to the native gtk widgets to show keyid.
A bit complicated but I'll put it in my personal notes and try to not forget it.

> Which I suppose is an aside from the original bug which does appear to be
> NAB, e.g. unzipping clippingimagestyles.pptx gives
> ppt/slideLayouts/slideLayout2.xml which has <p:cSld name="Title and
> Content"> in the document itself
Ok so no translation possible here.

Thank you for the detailed feedback!