Created attachment 171346 [details] sample file This is an issue I found while creating a unitest for bug 119793 < https://gerrit.libreoffice.org/c/core/+/114457 > Steps to reproduce: 1. Open attached document 2. Select the shape 3. Move it to the right 4. Type 'x' -> Since the shape is selected, it's inserted inside it. 5. Press undo -> the 'x' disappears 6. Press undo again -> The 'x' is again displayed Reproduced in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 93bb5fcba9e58eeeaaed9521c3bb4eecf9b91ac1 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=f582670131dc211e472960ecff1826f7b133b083 author Mike Kaganski <mike.kaganski@collabora.com> 2021-01-14 17:30:17 +0100 committer Mike Kaganski <mike.kaganski@collabora.com> 2021-01-15 07:26:48 +0100 commit f582670131dc211e472960ecff1826f7b133b083 (patch) tree 014a0e74ecaace01a2d9e7efbee119781ebb0a22 parent 9598018e67dfc10c35022cbec4844363b7dd98ab (diff) Use value comparison here Bisected with: bibisect-linux64-7.2 Adding Cc: to Mike Kaganski
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bfe800f773b0fe945452dc59205c156d0fc69462 tdf#141816: fix a thinko It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in a local build including the patch. @Mike, thanks for fixing this issue to quick !!
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/310f2ec225582df8701422e7c69ee40e1af50660 tdf#141816: sc_uicalc: Add unittest It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.