Bug 141888 - Crash on undo while in IM pre-selection in Calc, Impress and Math
Summary: Crash on undo while in IM pre-selection in Calc, Impress and Math
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-25 10:14 UTC by Jan-Marek Glogowski
Modified: 2023-11-28 03:13 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan-Marek Glogowski 2021-04-25 10:14:22 UTC
Found while fixing bug 141887 (Writer IM crash).

STR:

1. Start LO Calc, Impress, Draw or Math (not Writer! Didn't test Base)
2. Activate some IM and type a character, to be in IM pre-selection
3. Undo via shortcut (Ctrl+Z)

Expected result:
no crash

Actual result:
crash

soffice.bin: svl/source/undo/undo.cxx:679: bool SfxUndoManager::ImplUndo(SfxUndoContext*): Assertion `!"SfxUndoManager::Undo: not possible when within a list action!"' failed.

-----

All these modules create an undo entry while still in pre-selection (you can see the enabled undo toolbar button). Writer doesn't do that, so no crash happens. IMHO the other applications shouldn't create the Undo entry based on the pre-selection data, which would prevent the crash.
Comment 1 Roman Kuznetsov 2021-07-30 18:10:44 UTC
What's that IM, Jan-Marek?
Comment 2 Jan-Marek Glogowski 2021-07-30 18:42:50 UTC
(In reply to Roman Kuznetsov from comment #1)
> What's that IM, Jan-Marek?

IM = Input Method, mostly used for non-latin input, especially for complex symbolic languages, like Chinese, Japanese, etc. On Linux the most prominent ones are fcitx and ibus. Also often abbreviated as IME for Input Method Engine / Editor.

You normally get an extra window when typing, so the user can prepare the final symbol / input, which is sometimes referred to as the "pre-selection" window. Because it normally uses auto-completion features with multiple suggestions, just like virtual keyboards on a phone (which might actually be a IM to) for faster input.
Comment 3 Stéphane Guillou (stragu) 2023-04-30 10:17:17 UTC
Jan-Marek, can you still reproduce in recent versions?
I gave it a try with a Korean (Hangul) keyboard layout on Ubuntu 20.04 but I can't get a separate dialog for character entry.

I could see an issue in Calc where a character was following me when changing cells, and wasn't undoable, but I don't know if it's related.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: dd15364793401e41bae45cdeb410808c9f94fa93
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 4 QA Administrators 2023-10-28 03:13:26 UTC Comment hidden (obsolete)
Comment 5 QA Administrators 2023-11-28 03:13:13 UTC
Dear Jan-Marek Glogowski,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp