Bug 141909 - Calc: Switching to Read only leaves the lock files in place
Summary: Calc: Switching to Read only leaves the lock files in place
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.4.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
: 160463 (view as bug list)
Depends on:
Blocks: Read-Only
  Show dependency treegraph
 
Reported: 2021-04-26 10:41 UTC by Peter
Modified: 2024-08-06 15:48 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter 2021-04-26 10:41:38 UTC
Description:
Don't know if this is a bug or a feature:
When leaving edit mode (Shift-Ctrl-M), the lock files aren't removed.



Steps to Reproduce:
1. Open an existing spreadsheet in Calc. (There are lock files created in the document's directory in order to prevent others to concurrently edit the document.)
2. Untick "Edit mode" in menu "Edit" (retranslated it on my own; the original texts in german Calc version are: menu "Bearbeiten", menu item "Bearbeitungsmodus", Control-Shift-M).

3.

Actual Results:
To my surprise, despite the read only mode seems to be successfully entered, the lock files still exist. (And they still seems to nag other users trying to edit.)


Expected Results:
The lock files should be removed, like if openend with ticked "Read only" ("Nur lesen") in open file requester.


Reproducible: Always


User Profile Reset: No



Additional Info:
Maybe it has something to do with https://bugs.documentfoundation.org/show_bug.cgi?id=137793 -- albeit this deals about handling a file which is marked as "please open read only", not manually switching to read only.

Version: 7.0.4.2 (x64)
Build ID: dcf040e67528d9187c66b2379df5ea4407429775
CPU threads: 8; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 1 Peter 2021-04-26 13:20:29 UTC
Don't know the earliest affected version. The one reported is just the one I got.
Comment 2 Eleonora Govallo 2021-08-18 21:51:36 UTC
Repro in Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: adf65471e889676a600a9c6d0454c75cbd549ad3
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-08-13_04:44:18
Calc: threaded

Calc offered me to save changes before closing, but i could editr file.
Comment 3 BogdanB 2023-05-19 18:34:10 UTC
Seems solved.
Please retest.

Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 4 m_a_riosv 2024-04-02 01:37:10 UTC
*** Bug 160463 has been marked as a duplicate of this bug. ***
Comment 5 oeuceda 2024-08-06 15:48:45 UTC
(In reply to BogdanB from comment #3)
> Seems solved.
> Please retest.
> 
> Version: 7.5.3.2 (X86_64) / LibreOffice Community
> Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
> CPU threads: 16; OS: Linux 5.19; UI render: default; VCL: gtk3
> Locale: ro-RO (ro_RO.UTF-8); UI: en-US
> Calc: threaded

I have tested in 7.6.5.2 and now in 24.2.5.2, and I don't believe this has been solved. Calc still behaves poorly when dealing with files in read-only mode.

Yesterday I waited until my colleague opened a spreadsheet first (in full edit mode), I followed by opening the same file in read-only mode. A couple hours later he was unable to save his work because my instance of Calc had locked it. He didn't close the spreadsheet and re-open, so I suspect his computer went to sleep during his lunch break and it relinquished control of the file at that time. 

Regardless of how his Excel lost control of the document, a read-only instance of Calc on my computer should not have put a lock on his file. Once I closed Calc he was able to save his changes.

I've also found that when I open the file (in read-only mode) before he does, Calc locks it. This is not how read-only should work. Read-only Calc should behave as an observer, a spectator, and not interfere with other users.

Let me know if you need more info. Thanks.

-Oz