Bug 141934 - UI Some new line style presets previews are not rendered in the style selector dropdown
Summary: UI Some new line style presets previews are not rendered in the style selecto...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: 141933
  Show dependency treegraph
 
Reported: 2021-04-27 12:31 UTC by NISZ LibreOffice Team
Modified: 2021-05-11 04:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
attachment 171452 + Line dialog after compiling the proposed patch (42.53 KB, image/png)
2021-04-27 12:31 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-04-27 12:31:02 UTC
Created attachment 171454 [details]
attachment 171452 [details] + Line dialog after compiling the proposed patch

This is a followup to bug 141933
In the proposed patch (https://gerrit.libreoffice.org/c/core/+/114459) some very thin presets are added to LO, but the Line dialogs Style selector dropdown cannot render their previews.

Steps to reproduce:
    1. Open attachment 171452 [details] once bug 141933 is solved
    2. Select Format – Text Box and Shape – Line and observe the Line tabs Style dropdown 

Actual results:
Dot (Rounded) and Long Dot (Rounded) styles have no previews rendered.

Expected results:
Previews are rendered for these styles as well.
Comment 1 Commit Notification 2021-05-05 11:47:29 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b8c5236b444a9fbb1d419b95faf2ab2a71913efe

tdf#141934 svx dialog: fix missing dots in line style preview

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 László Németh 2021-05-05 11:51:02 UTC
tdf#141934 svx dialog: fix missing dots in line style preview

Line styles with dot-like dots (e.g the new
"rounded" preset line styles) got bad preview
with missing dots in the line style popup menus.

Follow-up to commit b9b2c6a98fec798fc0ec76ec3cd407724f19dcac
"tdf#141933 add preset dash styles with round cap".
Comment 3 BogdanB 2021-05-11 04:41:07 UTC
It's ok now. It has preview.

Verified in Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: d4f116d9576453f5974eb63db37a33c59ac53bc9
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded