Bug 142039 - Using "borders" tool is visibly very difficult on dark themes with Elementary icons
Summary: Using "borders" tool is visibly very difficult on dark themes with Elementary...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.1.5.2 release
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Icon-Themes Options-Dialog-Colours
  Show dependency treegraph
 
Reported: 2021-05-02 13:22 UTC by ominous
Modified: 2022-10-20 20:42 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
LibreOffice Calc Borders Dark Theme Issue (7.20 KB, image/png)
2021-05-02 13:22 UTC, ominous
Details
Comparison of toolbar and sidebar (69.73 KB, image/png)
2022-10-20 19:52 UTC, Rafael Lima
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ominous 2021-05-02 13:22:38 UTC
Created attachment 171592 [details]
LibreOffice Calc Borders Dark Theme Issue

Trying to get borders sorted correctly is very difficult.

It is very difficult for me to tell which tile does what on a dark theme.

Being colour blind might also attribute to this.

Would it be possible to make it more distinct?
Comment 1 Vladislav Kim 2021-07-24 17:21:35 UTC
Hello! Can you please attach the Libre Office version did you use and which color settings you apply?
Comment 2 ominous 2021-07-24 18:44:25 UTC
This was tested on both the latest Debian stable and Linux Mint, using the native dark themes those operating systems provide.
Comment 3 QA Administrators 2021-07-25 03:31:38 UTC Comment hidden (obsolete)
Comment 4 Stéphane Guillou (stragu) 2021-07-25 12:25:30 UTC
Hi Ominous! Thank you for the report.

Could you please provide us with one more bit of information:
- which Icon theme are you using? (Found in Tools > Options > LibreOffice > View)
- which version of LibreOffice are you using? (Copy and paste the information in Help > About LibreOffice)

Thank you!
Comment 5 Rizal Muttaqin 2021-11-18 22:55:23 UTC
Hi Omnious, thanks for the report!

From the screenshot you provided, I am pretty sure you are using elementary icon theme. As per now, elementary has no dark variant so I suggest you to switch to another icon theme which provide dark variant such like Breeze or Sifr. Install it from repo:

sudo apt install libreoffice-style-breeze
sudo apt install libreoffice-style-sifr


Or install LibreOffice build from TDF (https://www.libreoffice.org/download/download/)

For now I set this bug won't fix as I have no plan to add elementary dark variant but feel free to give more suggestion
Comment 6 Heiko Tietze 2021-11-19 07:10:51 UTC
(In reply to Rizal Muttaqin from comment #5)
> For now I set this bug won't fix as I have no plan to add elementary dark
> variant but feel free to give more suggestion

We had this topic before in respect to Breeze. And I remember vaguely that a few or even one pixel made a huge difference. Could that be a solution too for Elementary?
Comment 7 Rizal Muttaqin 2021-11-19 10:01:59 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to Rizal Muttaqin from comment #5)
> > For now I set this bug won't fix as I have no plan to add elementary dark
> > variant but feel free to give more suggestion
> 
> We had this topic before in respect to Breeze. And I remember vaguely that a
> few or even one pixel made a huge difference. Could that be a solution too
> for Elementary?

I don't know which topic do you refer and I don't get it what's "one pixel".
Set to NEW (just for the discussion reason only for now).
Comment 8 Heiko Tietze 2021-11-19 10:30:42 UTC
It was bug 86472, bug 107741 and bug 144637. With one pixel I was referring to moving the lines a bit away from the edge and to make it slightly larger.
Comment 9 Rafael Lima 2022-10-20 19:52:57 UTC
Created attachment 183173 [details]
Comparison of toolbar and sidebar

Recently the borders tool in the sidebar (Properties Deck - Cell Appearance) was improved and it looks great using Breeze (dark).

IMO we could use this new layout in the toolbar as well.

See the attached screenshot comparing both tools.
Comment 10 Stéphane Guillou (stragu) 2022-10-20 20:42:13 UTC
Back when this bug was first reported, the LibreOffice version in Debian stable was 6.1:  https://packages.debian.org/buster/all/allpackages

As mentioned in Comment 5, the issue was related to the Elementary icon set.

(In reply to Rafael Lima from comment #9)
> Created attachment 183173 [details]
> Comparison of toolbar and sidebar
> 
> Recently the borders tool in the sidebar (Properties Deck - Cell Appearance)
> was improved and it looks great using Breeze (dark).
> 
> IMO we could use this new layout in the toolbar as well.
> 
> See the attached screenshot comparing both tools.

I agree with Rafael that it would improve visibility, but I think a new bug should be opened for this specific Breeze issue. Regarding unifying toolbar and sidebar border choices, see Bug 146468.

As for this bug, I see it as resolved since the Elementary borders dropdown is now a lot more readable than it was when this bug was reported, with thicker orange lines -> marking as "Works for me".

Fixed in or before:

Version: 6.3.6.2
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded