Bug 142140 - Groupedbar Compact UI : the label of the print preview menu entry seems wrong
Summary: Groupedbar Compact UI : the label of the print preview menu entry seems wrong
Status: RESOLVED DUPLICATE of bug 118335
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.8.2 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks: Notebookbar-Groupedbar
  Show dependency tree / graph
 
Reported: 2021-05-07 03:38 UTC by Jérôme
Modified: 2023-06-16 22:06 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:

Attachments
the file menu (9.73 KB, image/png)
2021-05-07 03:38 UTC, Jérôme 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme 2021-05-07 03:38:24 UTC 
Created attachment 171728 [details]
the file menu

The French translation tells "exit print preview" in order to launch the print preview.
Comment 1 Roman Kuznetsov 2021-05-07 06:39:34 UTC 
Sophie, can you check it?
Comment 2 sophie 2021-05-07 10:52:05 UTC 
Thanks for reporting! Is it a version you downloaded on LibreOffice website? what is your OS? Can you copy the info you get in Help > About?
Comment 3 Ming Hua 2021-05-07 11:30:02 UTC 
Reproduced with 7.2 daily build:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 18e5e948dd66e41f17b0a63bf631d98aee84a03b
CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: zh-CN (zh_CN); UI: en-US
Calc: threaded

This is not a translation issue.  The original English string is "Close Preview", KeyID RmzBC:
https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/fr/?checksum=57c6056115344eba

According to the reporter's screenshot, the string is shown in "Groupedbar Compact" UI variant, Writer's "File" dropdown menu.  The item is a toggle option (with the usual check mark indicator) to switch on/off print preview mode, but the label never changes.  Probably should be renamed to "Enable Print Preview" or something.
Comment 4 sophie 2021-05-07 11:45:15 UTC 
 (In reply to Ming Hua from comment #3)
> Reproduced with 7.2 daily build:
> Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: 18e5e948dd66e41f17b0a63bf631d98aee84a03b
> CPU threads: 2; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL:
> win
> Locale: zh-CN (zh_CN); UI: en-US
> Calc: threaded
> 
> This is not a translation issue.  The original English string is "Close
> Preview", KeyID RmzBC:
> https://translations.documentfoundation.org/translate/libo_ui-master/
> officecfgregistrydataorgopenofficeofficeui/fr/?checksum=57c6056115344eba

Thanks for investigating, I'm able to reproduce it now
> 
> According to the reporter's screenshot, the string is shown in "Groupedbar
> Compact" UI variant, Writer's "File" dropdown menu.  The item is a toggle
> option (with the usual check mark indicator) to switch on/off print preview
> mode, but the label never changes.  Probably should be renamed to "Enable
> Print Preview" or something.

We use "Print Preview" in several places, the "Close Print Preview" label is used in the Print preview window. Maybe the wrong label has been used. Something for you Heiko?
Comment 5 Jérôme 2021-05-07 20:12:44 UTC 
(In reply to sophie from comment #2)
> Thanks for reporting! Is it a version you downloaded on LibreOffice website?
> what is your OS? Can you copy the info you get in Help > About?

I experienced this bug with a 6.4 version shipped with a GNU/Linux distro or a 6.2 version on a Windows OS.
Comment 6 Heiko Tietze 2021-05-10 10:53:02 UTC 
Obviously, the Notebookbar [1] has a menu item .uno:PrintPreview, defined in [2], uses not the Label but the PopupLabel. Can/Should we change this?

[1] sw/uiconfig/swriter/ui/notebookbar_groupedbar_compact.ui
[2] officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
Comment 7 Heiko Tietze 2022-01-31 09:36:33 UTC 
For code pointer see comment 3.
Comment 8 Justin L 2023-06-16 22:06:50 UTC 

*** This bug has been marked as a duplicate of bug 118335 ***