Bug 142157 - "Insert text from file" removes imported section if section lower border is at the end of imported ODT.
Summary: "Insert text from file" removes imported section if section lower border is a...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: filters and storage (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-07 15:05 UTC by Georgy Litvinov
Modified: 2021-05-21 10:09 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample document with text in section to insert text from (10.00 KB, application/vnd.oasis.opendocument.text)
2021-05-10 17:24 UTC, Georgy Litvinov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Litvinov 2021-05-07 15:05:30 UTC
Description:
If the imported document has a section at the end of the document, the section is removed on import. 

Steps to Reproduce:
1. Open Writer document
2. Open menu Insert -> Text from file
3. Choose file with section at the end of document

Actual Results:
No section imported from the document.

Expected Results:
Imported section exists in the document.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 8ae3ae4bf75fdd0aaa132c956d9da029baa3adc6
CPU threads: 8; OS: Linux 3.10; UI render: Skia/Vulkan; VCL: gtk3
Locale: en-GB (en_GB.utf8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-04-23_17:13:02
Calc: threaded
Comment 1 Harshita Nag 2021-05-10 16:55:15 UTC
Please attach a sample document.
Comment 2 Georgy Litvinov 2021-05-10 17:24:13 UTC
Created attachment 171833 [details]
Sample document with text in section to insert text from
Comment 3 Roman Kuznetsov 2021-05-15 09:36:53 UTC
https://gerrit.libreoffice.org/c/core/+/115643
Comment 4 Commit Notification 2021-05-18 11:36:42 UTC
Georgy Litvinov committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f5ac56c9f7f54bb6603f6f1e8dba06da20f7e0a4

Don't remove section at the end of inserted text tdf#142157

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-05-20 22:34:57 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/aa6e9cceddfb154c2207ab316cb7625655452953

tdf#142157: sw_uiwriter: Add unittest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.