Bug 142179 - Table layout is updated/footnotes re-arranged after clicking inside a table (placing cursor inside) causing noticeable lag every time
Summary: Table layout is updated/footnotes re-arranged after clicking inside a table (...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: Writer-Tables
  Show dependency tree / graph
 
Reported: 2021-05-09 10:32 UTC by Telesto
Modified: 2022-11-23 11:02 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-05-09 10:32:16 UTC 
Description:
Table layout is updated/footnotes re-arranged after clicking inside a table (placing cursor inside)

Steps to Reproduce:
1. Open attachment 152139 [details]
2. Freeze clicking inside table

Actual Results:
Freeze (relayouting) on every entry/exit of table (seen in multi page view, but also lag in single page)

Expected Results:
No layout activity when entering/exiting table (without any change)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 9df3aa7ea72d61462e430643f2a80906dce4e15b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL
Comment 1 Telesto 2021-05-09 10:33:44 UTC 
Not seen in
Version: 6.2.0.0.alpha0+
Build ID: b1d1edff4e81a8299e2a17c7e562d144329549ab
CPU threads: 4; OS: Windows 6.3; UI render: GL; 
Locale: nl-NL (nl_NL); Calc: CL
Comment 2 Telesto 2021-05-09 10:35:55 UTC 
Looping around in 6.4
Comment 3 Telesto 2021-05-09 10:37:34 UTC 
Open issue in 6.4 got fixed, however without the enter table part which apparently acting as trigger. The bibisect for the fix will point to different bug (as layout loop being present in 6.4 and not in 6.2)
Comment 4 Dieter 2021-05-24 05:47:36 UTC 
I can't reproduce this is the described way: LO freezes sometimes for 3 or 4 seconds and I could see relayouting only once (I clicked more than 20 times) 

Version: 7.1.3.2 (x64) / LibreOffice Community
Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL
Comment 5 Buovjaga 2022-05-10 07:00:59 UTC 
Bibisected with linux-64-6.4 to
https://git.libreoffice.org/core/commit/c56bf1479cc71d1a2b0639f6383e90c1f7e3655b
tdf#105330 sw: fix lost cursor on undoing nested table insert
Comment 6 Miklos Vajna 2022-05-10 07:06:43 UTC 
The above is a revert of core.git commit e4509eea8fc7c07ddff48edf0d4c015c2663d896, i.e. the above never truly worked. It "worked" by introducing problems like bug 105330. I would argue that keeping 105330 fixed and fixing this bug is a good goal, but it's not a regression, since in the past only one of them worked at the same time.

OK to adjust the keywords accordingly?
Comment 7 Gabor Kelemen (allotropia) 2022-11-14 23:05:28 UTC 
This no longer happens in 7.4 after

https://git.libreoffice.org/core/+/cc7de9022b83c4103f1dc9ba6a8c1a8a98a21324

author	Michael Stahl <michael.stahl@allotropia.de>	Mon Jul 11 19:20:33 2022 +0200
committer	Thorsten Behrens <thorsten.behrens@allotropia.de>	Thu Jul 14 23:03:06 2022 +0200

sw: fix spurious layout invalidation from ~SwCallLink()

Thanks Michael!