Bug 142254 - UI: Navigator shows deleted images - still in track changes - while show track changes being disabled
Summary: UI: Navigator shows deleted images - still in track changes - while show trac...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Track-Changes
  Show dependency treegraph
 
Reported: 2021-05-13 09:10 UTC by Telesto
Modified: 2023-09-15 07:44 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison of Word and Writer master (160.88 KB, image/png)
2021-05-13 10:29 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-05-13 09:10:09 UTC
Description:
Navigator shows deleted images - still in track changes - while show track changes being disabled

Steps to Reproduce:
1. Open attachment 164527 [details]
2. Go to navigator panel, notice the image entry (greyed out)

Actual Results:
Greyed out image entry

Expected Results:
No image entry, as long as track & changes show not being enabled (why show images in navigator which can't see?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d7f734db2c078ced3ce08ad58cd816a79abe3bcf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 NISZ LibreOffice Team 2021-05-13 10:29:55 UTC
Created attachment 171955 [details]
Comparison of Word and Writer master

Here I opened attachment 155969 [details] from bug 128913 in Word side by side with the linked document in Writer master.

Some observations:
The docx contains two images, one deleted one added. The added image is listed in the Selection panel on the right, while the deleted is not. Rejecting the deletion shows that image too.
The Navigation pane on the left however finds both when searching for graphical items.

The odt displays the deleted frame and image in the Navigator as hidden. Rejecting the changes or showing the changes makes them active in the Navigator.
Comment 2 NISZ LibreOffice Team 2021-05-13 10:37:38 UTC
Also: the odt document contains a comment which is also TC-deleted and completely hidden from the Navigator when the changes are hidden.

Current behavior is not consistent with this.

Confirming in master:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dbd4110cc36011042c98549d997daa79e8065aba
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 3 Heiko Tietze 2021-05-17 10:47:28 UTC
Keeping deleted images visible is a new feature in 7.2 - other content such as tables, charts or formulas are not tracked and deletion removes the object from the Navigator. But images are treated in the same way as text and if I delete a heading it will remain in the Navigator.

We have two options: a) remove deleted objects from the Navigator or b) mark it respectively, eg. per strike trough font. Would prefer b).
Comment 4 Telesto 2021-05-19 14:12:57 UTC
@Heiko

(In reply to Heiko Tietze from comment #3)
> Keeping deleted images visible is a new feature in 7.2 - other content such
> as tables, charts or formulas are not tracked and deletion removes the
> object from the Navigator. But images are treated in the same way as text
> and if I delete a heading it will remain in the Navigator.
> 
> We have two options: a) remove deleted objects from the Navigator or b) mark
> it respectively, eg. per strike trough font. Would prefer b).

Out of curiosity, what's the use case to show 'deleted' - record by track changes -  content within the navigator while hidden?

You add a lot of variables. 
* Can you rename deleted (invisible) stuff? 
* Can you click on strike through images. (double click does show the image.. except when it's hidden)
* Does showing the hidden stuff disturb the usefulness of navigator (have some seen some documents with a lot of images/references). Which makes scrolling necessary already. Adding 'even more' junk to it..
* And what if the charts, tables, formula's are added to track changes (I think this will happen someday...)

So kind of wondering what the usefulness of showing 'hidden' stuff would be. Obviously it should be present if track changes is on 'show mode". But else?
Comment 5 Heiko Tietze 2021-05-19 16:27:06 UTC
Consistency with the document where you still see the object. Sure, if TC are not shown we could hide the deleted content from the Navigator as well.