Bug 142358 - Impress: Undo merge cells changes distribution of table cells
Summary: Impress: Undo merge cells changes distribution of table cells
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: ImpressDraw-Tables
  Show dependency tree / graph
 
Reported: 2021-05-18 15:33 UTC by Telesto
Modified: 2024-02-19 22:38 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-05-18 15:33:53 UTC 
Description:
Impress: Undo merge cells changes distribution of table cells

Steps to Reproduce:
1. Open Impress
2. Insert 3x3 table
3. Select all cells
4. Press Merge cells
5. Undo

Actual Results:
Disproportional distribution

Expected Results:
Proportional distribution as initially


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d7f734db2c078ced3ce08ad58cd816a79abe3bcf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-05-18 15:39:25 UTC 
Crash with 
7.0

and 6.0

behaviour as seen with 7.2 in 
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

and with
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)

Still OK with
LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735
Comment 2 Timur 2021-05-19 09:33:47 UTC Comment hidden (obsolete)
Comment 3 Buovjaga 2021-05-19 10:21:51 UTC 
(In reply to Timur from comment #2)
> Repro 7.2+.
> 
> I couldn't run Impress in 43all oldest or 3.6. And in 4.0, bug is there.
> So unless someone can circumvent, I set notBibisectable.

43all repo is annoying because the user profile regularly becomes corrupted and LibO refuses to launch. Most of the time when I start bibisecting I have to first rm -rf ~/.config/libreoffice/3/user

Maybe your problem was this?
Comment 4 Timur 2021-05-19 11:33:20 UTC 
Thanks to Buovjaga, here is 43all range:

commit 0e54cced22ee8d216a783202cf26384317db0959
Date:   Mon Dec 10 04:23:21 2012 +0000

    source-hash-2815396a1813cb3956c5aba066de49a7f34bc657
    Author:     Michael Stahl <mstahl@redhat.com>
    AuthorDate: Tue Jul 31 17:25:44 2012 +0200
    Commit:     Michael Stahl <mstahl@redhat.com>
    CommitDate: Tue Jul 31 20:26:45 2012 +0200
        _SetGetExpFlds: this looks simpler with upper_bound
        Change-Id: I37dd291aaa229493141fbb8b426488e8e4427185
    previous source-hash-83837d6514217c82ebe8d56dddf89fa34f4b5435

https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=83837d6514217c82ebe8d56dddf89fa34f4b5435..2815396a1813cb3956c5aba066de49a7f34bc657
Comment 5 Timur 2021-05-19 11:36:38 UTC 
Not obvious what's the offending commit, I'd go with this one (try to build without):
author	Uray M. János <uray.janos@gmail.com>	2012-07-30 11:42:16 +0200
committer	Noel Power <noel.power@novell.com>	2012-07-30 14:55:40 +0100
commit 9348c529d34b0bb457e750b3d5bcbb348995367e (patch)
tree 14efcc16274ff2c4eb64f0a05a617e3da49fddaa
parent 1fd10dd070868a28af3de3bf7ad4e74918f8ce69 (diff)
fdo#46968 fixing undo of textbox resizing
Change-Id: Ic647e5c337987985f749b67113892a01f74ee8f9
Comment 6 QA Administrators 2023-08-22 03:05:52 UTC Comment hidden (obsolete)
Comment 7 Tex2002ans 2024-02-19 22:38:26 UTC 
Still reproduce in:

Version: 24.2.0.3 (X86_64) / LibreOffice Community
Build ID: da48488a73ddd66ea24cf16bbc4f7b9c08e9bea1
CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Followed comment 0 exactly.

- - -

After Undo (Ctrl+Z), they go from:

- 3 evenly distributed columns

into:

- 1 huge column
- 1 medium column
- 1 teeny tiny column