Bug 142441 - UI: Table properties borders doesn't show top border if row selected
Summary: UI: Table properties borders doesn't show top border if row selected
Status: RESOLVED DUPLICATE of bug 143250
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks:
 
Reported: 2021-05-23 08:00 UTC by Telesto
Modified: 2022-01-06 15:43 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file (8.50 KB, application/vnd.oasis.opendocument.text)
2021-05-23 08:00 UTC, Telesto 		Details
Screencast (410.22 KB, video/mp4)
2021-05-25 10:02 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-05-23 08:00:17 UTC 
Description:
UI: Table properties borders doesn't show top border if row selected

Steps to Reproduce:
1. Open the attached file
2. Select the middle row
3. Table -> Properties -> Border



Actual Results:
Top border appears to be empty

Expected Results:
Not empty, but shows the present border


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 05366b8e6683363688de8708a3d88cf144c7a2bf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
3.3.0
Comment 1 Telesto 2021-05-23 08:00:37 UTC 
Created attachment 172259 [details]
Example file
Comment 2 Heiko Tietze 2021-05-25 08:17:55 UTC 
You have set the border exactly like this (change the extension into zip and check how style:table-cell-properties are defined in content.xml).

Point is that drawing a line below a cell is the same as on top for the following. Drawing two lines over each other is just a waste of resources.
Comment 3 Telesto 2021-05-25 10:02:08 UTC 
Created attachment 172321 [details]
Screencast

(In reply to Heiko Tietze from comment #2)
> You have set the border exactly like this (change the extension into zip and
> check how style:table-cell-properties are defined in content.xml).
> 
> Point is that drawing a line below a cell is the same as on top for the
> following. Drawing two lines over each other is just a waste of resources.

Not following.. This is also about usability (next to presenting factual state). See screencast

[BTW, I'm aware tables handling being tremendously complex]
Comment 4 Heiko Tietze 2021-05-31 11:12:39 UTC 
(In reply to Telesto from comment #3)
> Not following.. 

If you have adjacent cells the border from one is used at the other, obviously. Likely because of performance. I'd resolve the ticket as WF, the alternative is to either always draw the lines risking performance issues or to fake the border into the UI which sounds also not like a good solution. But since bug 142440 is probably caused by this issue we should rethink the processing anyway.
Comment 5 Telesto 2021-07-08 08:11:41 UTC 

*** This bug has been marked as a duplicate of bug 143248 ***
Comment 6 Telesto 2021-07-08 08:12:21 UTC 

*** This bug has been marked as a duplicate of bug 143250 ***