Bug 142499 - Make 'fat cross' cursor optional
Summary: Make 'fat cross' cursor optional
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.0.0 alpha1+
Hardware: All All
: medium enhancement
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.3.0 target:7.2.0.0.beta2
Keywords: needsUXEval
Depends on:
Blocks: Mouse-Cursor
  Show dependency treegraph
 
Reported: 2021-05-26 13:21 UTC by V Stuart Foote
Modified: 2021-09-09 12:45 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description V Stuart Foote 2021-05-26 13:21:20 UTC
The graphic for the new 'fat cross' cursor needs some refinement. Absent that, cursor used for the cell selection should be selectable--restore legacy arrow pointer as an option and allow user to set their default curson.
Comment 1 Heiko Tietze 2021-05-27 09:40:16 UTC
AFAIK icon themes can define the cursor (not sure whether this works for all OS). Regarding the option I like the idea to have a switch whether the system default is used or this themed cursor.
Comment 2 Commit Notification 2021-06-15 13:04:41 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/10ff27cc4f01693865599d24caf7ab80d95232e0

Resolves tdf#142499 - Make fat cross cursor optional

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Heiko Tietze 2021-06-15 13:06:47 UTC
Tools > Options > Calc > View has now radio buttons to choose between Themed (fat cross) and System (arrow).
Comment 4 Commit Notification 2021-06-15 16:21:05 UTC
Heiko Tietze committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/51fd769bb358236023c9026c11b2b76268dda99b

Resolves tdf#142499 - Make fat cross cursor optional

It will be available in 7.2.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 BogdanB 2021-06-17 13:33:00 UTC
It's fixed.
Verified in
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c703b2d22c3f45825d9c9d790c3b5a4b6f97e776
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded
Comment 6 BogdanB 2021-06-17 13:34:29 UTC
It's great that "System" is checked by default.
Comment 7 Martin Srebotnjak 2021-06-17 20:40:46 UTC
Beta2 should not introduce any new features, beta1 should lock the features.
Who decided this can be added later?
Did you discuss this with l10n teams?
Comment 8 Heiko Tietze 2021-06-18 08:40:27 UTC
(In reply to Martin Srebotnjak from comment #7)
> Beta2 should not introduce any new features, beta1 should lock the features.
> Who decided this can be added later?
> Did you discuss this with l10n teams?

You are quite picky with one day, and string/UI freeze is July 5-11. Without the option we would had to consider reverting the fat-cross patch.
Comment 9 b. 2021-06-18 14:08:43 UTC
i would support @Heiko Tietze's approach, either undo / delay the 'fatcross' beyond 7.2, or make it optional already in 7.2. IMHO it is important not to annoy users with difficulties / inconveniences in the UI ...
Comment 10 b. 2021-06-22 02:21:57 UTC
had time to check, it works, @Heiko Tietze: well done, thank you!
Comment 11 Rizal Muttaqin 2021-09-04 11:24:43 UTC
(In reply to Heiko Tietze from comment #1)
> AFAIK icon themes can define the cursor (not sure whether this works for all
> OS). Regarding the option I like the idea to have a switch whether the
> system default is used or this themed cursor.

 have created a slimmer variant for Sukapura theme, but it does not work. The cursor is still fat. So, it's not themeable? I am sure this ticket does not cover themeabilty. Could someone please point me the bug number?


Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 9b8a4171c5ef9f2b88b73007e394774b4ab84a66
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: kf5 (cairo+xcb)
Locale: id-ID (id_ID.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-08-30_13:20:16
Calc: threaded
Comment 12 Heiko Tietze 2021-09-06 07:54:13 UTC
(In reply to Rizal Muttaqin from comment #11)
> it's not themeable? ... VCL: kf5 (cairo+xcb)

Happens only on kf5 and gen, see bug 144302.