Bug 142511 - Missing inset margin for frame around character attributes within font features dialog
Summary: Missing inset margin for frame around character attributes within font featur...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.3.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Fonts
  Show dependency treegraph
 
Reported: 2021-05-26 20:16 UTC by Thorsten Wagner
Modified: 2023-08-08 11:49 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (43.87 KB, image/png)
2021-05-26 20:17 UTC, Thorsten Wagner
Details
Screenshot (162.95 KB, image/png)
2021-05-27 13:41 UTC, Thorsten Wagner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Wagner 2021-05-26 20:16:37 UTC
Description:
Black frame lines are drawn around character attributes (see screenshot for an example). This does not look compliant to macOS UI theme at least. Issue is existing with GTK too (and maybe with the other widget libraries as well). Issue is a follow up from tdf#125508.

Steps to Reproduce:
1. Open Writer
2. Open Character dialog
3. Open Features dialog

Actual Results:
Black frame lines around font attributes

Expected Results:
No frame lines around font attributes


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.3.2.0+ / LibreOffice Community
Build ID: 162213c78ede269b255c1eddaaac013975a34ee2
CPU threads: 8; OS: Mac OS X 10.15.7; UI render: GL; VCL: osx
Locale: de-DE (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 1 Thorsten Wagner 2021-05-26 20:17:11 UTC
Created attachment 172375 [details]
Screenshot
Comment 2 Heiko Tietze 2021-05-27 09:00:06 UTC
The number of options can block accessibility of the dialog [1] and we put the checkboxes into a scrollwindow to solve bug 128176. What can we do to make this more appealing?

[1] cui/uiconfig/ui/fontfeaturesdialog.ui
Comment 3 Thorsten Wagner 2021-05-27 13:41:22 UTC
Okay, I see. It looks as not intended when no scollbars are displayed only. Two optimizations:

(1) List box frame around checkboxes should cover the whole dialog width. Currently this is only the case if checkboxes width exceeds preview width.

(2) An inset margin should be used inside the listbox (see screenshot attached).
Comment 4 Thorsten Wagner 2021-05-27 13:41:39 UTC
Created attachment 172394 [details]
Screenshot
Comment 5 Thorsten Wagner 2021-06-07 18:49:13 UTC
No better idea, but an inset margin is required at least within the frame
Comment 6 Heiko Tietze 2021-06-11 08:52:46 UTC
Yes, I fully agree. About the margins we have some numbers defined in https://wiki.documentfoundation.org/Design/Guidelines/PropertyDialog
Comment 7 QA Administrators 2023-06-12 03:11:28 UTC
Dear Thorsten Wagner,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug