Bug 142872 - Captioned image doubled in HTML export
Summary: Captioned image doubled in HTML export
Status: RESOLVED DUPLICATE of bug 142871
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: (X)HTML-Export
  Show dependency tree / graph
 
Reported: 2021-06-15 09:26 UTC by Eyal Rozenberg
Modified: 2021-07-02 18:05 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
document exhibiting the issue (ODT + HTML) (13.36 KB, application/zip)
2021-06-15 09:27 UTC, Eyal Rozenberg 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eyal Rozenberg 2021-06-15 09:26:01 UTC 
In Writer,

1. Create a new document.
2. Insert a smiley-face shape (Insert | Shapes | Symbols | Smiley Face); make it a few paragraphs' height and of similar width
3. Add a caption to the smiley-face, with text "Don't worry, be happy!"
4. Save the document as HTML
5. Open the HTML in a browser.

Expected result: You see the smiley face once in the HTML.

Actual result: You see the smiley face twice, one below the other.
Comment 1 Eyal Rozenberg 2021-06-15 09:27:09 UTC 
Created attachment 172901 [details]
document exhibiting the issue (ODT + HTML)

Note there's a single GIF file, referenced twice by the HTML.
Comment 2 Eyal Rozenberg 2021-06-15 09:27:23 UTC 
Seen with:

Version: 7.2.0.0.alpha1+ / LibreOffice Community
Build ID: 162f5a20095c6937030d23ee03fb8f72c51eefa1
CPU threads: 4; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: en-US (en_IL); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-06-06_16:55:45
Comment 3 Telesto 2021-06-16 04:49:11 UTC 
Repro
Version: 7.2.0.0.alpha1+ (x64) / LibreOffice Community
Build ID: 239b4bb27fd8db26e8416045b3015688a8b1b0ae
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

not with
Version: 7.1.0.0.beta1+ (x64)
Build ID: f9fab4203c1aa0b9a3f27ce2713b6d5addc7df19
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL
Comment 4 psidiumcode 2021-06-17 18:49:13 UTC 
bisect information:
 be872312b348a55f7f07f6fbb1e08cb55b71f53a is the first bad commit
commit be872312b348a55f7f07f6fbb1e08cb55b71f53a
Author: libreoffice <libreoffice@libreoffices-Mac-mini.local>
Date:   Mon Jun 14 17:58:16 2021 +0200

    source e76471c5ce725dae9abb6f78b7674c6f77df34f4
    
    source e76471c5ce725dae9abb6f78b7674c6f77df34f4

 LibreOffice.app/Contents/Frameworks/libswlo.dylib  | Bin 18590944 -> 18591040 bytes
 .../Contents/Resources/config/images_breeze.zip    | Bin 1893222 -> 1893222 bytes
 .../Resources/config/images_breeze_dark.zip        | Bin 1888888 -> 1888888 bytes
 .../Resources/config/images_breeze_dark_svg.zip    | Bin 1571133 -> 1571133 bytes
 .../Resources/config/images_breeze_svg.zip         | Bin 1568649 -> 1568649 bytes
 .../Contents/Resources/config/images_colibre.zip   | Bin 2785191 -> 2785191 bytes
 .../Resources/config/images_colibre_svg.zip        | Bin 2899838 -> 2899838 bytes
 .../Resources/config/images_elementary.zip         | Bin 4198427 -> 4198427 bytes
 .../Resources/config/images_elementary_svg.zip     | Bin 5520392 -> 5520392 bytes
 .../Resources/config/images_karasa_jaga.zip        | Bin 4887661 -> 4887661 bytes
 .../Resources/config/images_karasa_jaga_svg.zip    | Bin 19328964 -> 19328964 bytes
 .../Contents/Resources/config/images_sifr.zip      | Bin 2109031 -> 2109031 bytes
 .../Contents/Resources/config/images_sifr_dark.zip | Bin 2110980 -> 2110980 bytes
 .../Resources/config/images_sifr_dark_svg.zip      | Bin 1760991 -> 1760991 bytes
 .../Contents/Resources/config/images_sifr_svg.zip  | Bin 1757096 -> 1757096 bytes
 .../Contents/Resources/config/images_sukapura.zip  | Bin 3046042 -> 3046042 bytes
 .../Resources/config/images_sukapura_svg.zip       | Bin 4356159 -> 4356159 bytes
 LibreOffice.app/Contents/Resources/setuprc         |   2 +-
 LibreOffice.app/Contents/Resources/versionrc       |   2 +-
 19 files changed, 2 insertions(+), 2 deletions(-)
Comment 5 psidiumcode 2021-06-17 18:50:18 UTC 
bisect log:

# bad: [20651168152192ab9e0f9d12a94228b24125b0d4] source 3d311c6d63eafbe2f76d6f1768dc3f675970a55a
# good: [25b063cc33a4d47d0c559132b4460218fd6168fe] source 5c682a5e24337ac022fb3eba585583b16718d246
git bisect start 'master' '25b063cc33a4d47d0c559132b4460218fd6168fe'
# good: [1a943bbc388d5c1cca596e35a53d54740d163d85] source 447d13023dcba333d34aba315e9093d1c82b8912
git bisect good 1a943bbc388d5c1cca596e35a53d54740d163d85
# bad: [d03ccb025ebef11f020240245008bb3be8e34611] source c617b11ff37a18225f9666b7d028a734d12b360a
git bisect bad d03ccb025ebef11f020240245008bb3be8e34611
# bad: [5882c66a180fd129fe5863cee664d311876fa8de] source 6a8e7beef4f75e348536f971254fd4fd23c1806e
git bisect bad 5882c66a180fd129fe5863cee664d311876fa8de
# good: [dfcd39e352d83fdaadde76bfbdc36a6aa778f2f0] source e7afd6407401014f9eee6cbce0f80da7c0491a4e
git bisect good dfcd39e352d83fdaadde76bfbdc36a6aa778f2f0
# good: [c1d41723a0d47b325e8a2f44806aa34959f26eb2] source 8771f48512ed19197c17506f522578f43b092b21
git bisect good c1d41723a0d47b325e8a2f44806aa34959f26eb2
# bad: [4e0f27cedbfc5c5e50d39d550a4c48dd3bda1f8a] source ef0d150675687469ca85de62b67e34c1e3daa176
git bisect bad 4e0f27cedbfc5c5e50d39d550a4c48dd3bda1f8a
# good: [e82b51b1c666f14a6b9175731f297365f211e553] source 08b7529f628eda1d209cf27f9bbe52ee336fef62
git bisect good e82b51b1c666f14a6b9175731f297365f211e553
# bad: [904778bcbc32eeaaea0330a6dc9b7d288976729a] source f1be88688cf1ca4ab14f93ae1a75e0331a6577cb
git bisect bad 904778bcbc32eeaaea0330a6dc9b7d288976729a
# bad: [2c54e1bdeb4512807991cc983c0f69b88f22daca] source e4e24a2f996989c3e7969aab71a9db78f1b41889
git bisect bad 2c54e1bdeb4512807991cc983c0f69b88f22daca
# bad: [be872312b348a55f7f07f6fbb1e08cb55b71f53a] source e76471c5ce725dae9abb6f78b7674c6f77df34f4
git bisect bad be872312b348a55f7f07f6fbb1e08cb55b71f53a
# first bad commit: [be872312b348a55f7f07f6fbb1e08cb55b71f53a] source e76471c5ce725dae9abb6f78b7674c6f77df34f4
momoko@Tocte mac64-7.2 % git bisect log
# bad: [20651168152192ab9e0f9d12a94228b24125b0d4] source 3d311c6d63eafbe2f76d6f1768dc3f675970a55a
# good: [25b063cc33a4d47d0c559132b4460218fd6168fe] source 5c682a5e24337ac022fb3eba585583b16718d246
git bisect start 'master' '25b063cc33a4d47d0c559132b4460218fd6168fe'
# good: [1a943bbc388d5c1cca596e35a53d54740d163d85] source 447d13023dcba333d34aba315e9093d1c82b8912
git bisect good 1a943bbc388d5c1cca596e35a53d54740d163d85
# bad: [d03ccb025ebef11f020240245008bb3be8e34611] source c617b11ff37a18225f9666b7d028a734d12b360a
git bisect bad d03ccb025ebef11f020240245008bb3be8e34611
# bad: [5882c66a180fd129fe5863cee664d311876fa8de] source 6a8e7beef4f75e348536f971254fd4fd23c1806e
git bisect bad 5882c66a180fd129fe5863cee664d311876fa8de
# good: [dfcd39e352d83fdaadde76bfbdc36a6aa778f2f0] source e7afd6407401014f9eee6cbce0f80da7c0491a4e
git bisect good dfcd39e352d83fdaadde76bfbdc36a6aa778f2f0
# good: [c1d41723a0d47b325e8a2f44806aa34959f26eb2] source 8771f48512ed19197c17506f522578f43b092b21
git bisect good c1d41723a0d47b325e8a2f44806aa34959f26eb2
# bad: [4e0f27cedbfc5c5e50d39d550a4c48dd3bda1f8a] source ef0d150675687469ca85de62b67e34c1e3daa176
git bisect bad 4e0f27cedbfc5c5e50d39d550a4c48dd3bda1f8a
# good: [e82b51b1c666f14a6b9175731f297365f211e553] source 08b7529f628eda1d209cf27f9bbe52ee336fef62
git bisect good e82b51b1c666f14a6b9175731f297365f211e553
# bad: [904778bcbc32eeaaea0330a6dc9b7d288976729a] source f1be88688cf1ca4ab14f93ae1a75e0331a6577cb
git bisect bad 904778bcbc32eeaaea0330a6dc9b7d288976729a
# bad: [2c54e1bdeb4512807991cc983c0f69b88f22daca] source e4e24a2f996989c3e7969aab71a9db78f1b41889
git bisect bad 2c54e1bdeb4512807991cc983c0f69b88f22daca
# bad: [be872312b348a55f7f07f6fbb1e08cb55b71f53a] source e76471c5ce725dae9abb6f78b7674c6f77df34f4
git bisect bad be872312b348a55f7f07f6fbb1e08cb55b71f53a
# first bad commit: [be872312b348a55f7f07f6fbb1e08cb55b71f53a] source e76471c5ce725dae9abb6f78b7674c6f77df34f4
Comment 6 Buovjaga 2021-07-01 16:02:07 UTC 
(In reply to psidiumcode from comment #4)
> bisect information:
> 
> be872312b348a55f7f07f6fbb1e08cb55b71f53a is the first bad commit
> commit be872312b348a55f7f07f6fbb1e08cb55b71f53a
> Author: libreoffice <libreoffice@libreoffices-Mac-mini.local>
> Date:   Mon Jun 14 17:58:16 2021 +0200
> 
>     source e76471c5ce725dae9abb6f78b7674c6f77df34f4
>     
>     source e76471c5ce725dae9abb6f78b7674c6f77df34f4

Confirmed with bibisect-linux64-7.2

https://git.libreoffice.org/core/commit/e76471c5ce725dae9abb6f78b7674c6f77df34f4
sw XHTML / reqif export: export non-PNG graphic shapes directly

Adding Cc: to Miklos Vajna
Comment 7 Miklos Vajna 2021-07-01 19:02:08 UTC 
Could you please test if this is a duplicate of bug 142871, now that it is fixed? Thanks.
Comment 8 Eyal Rozenberg 2021-07-01 21:30:02 UTC 
(In reply to Miklos Vajna from comment #7)
> Could you please test

By "you", do you mean me? Anyway, if you link to a relevant build, I'll check. But if you wrote the fix, then - the reproduction instructions are really trivial, it would take you less than a minute to check.
Comment 9 Buovjaga 2021-07-02 18:05:33 UTC 
Yep, it's a dupe, thanks for fixing!

Arch Linux 64-bit
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: a43dac7964a889c8a0f01a38f0a9d178f4edb44d
CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 2 July 2021

*** This bug has been marked as a duplicate of bug 142871 ***