Bug 143231 - Spellcheck: "correct all" replaces all same errors only up to the next misspelling
Summary: Spellcheck: "correct all" replaces all same errors only up to the next misspe...
Status: RESOLVED DUPLICATE of bug 91151
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-07-07 10:00 UTC by birnbach@posteo.de
Modified: 2024-06-11 03:26 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
blind text with 26 occurrences of the word Lorem (25.27 KB, application/vnd.oasis.opendocument.text)
2021-07-07 10:05 UTC, birnbach@posteo.de
Details

Note You need to log in before you can comment on or make changes to this bug.
Description birnbach@posteo.de 2021-07-07 10:00:00 UTC
Description:
When finding a misspelled word spellcheck offers replacement of current word with proposed correct version (button "change") or all occurrences throughout the text (button "change all").

Both buttons replace only the current word.

Steps to Reproduce:
1. create text document with N (2 or more) occurrences of a word that does not exist (e.g. "Lorem" from a lorem ipsum generator)
2. start spellcheck
3. replacement of said word will be offered ("Loren" in above example)
4. press "replace all"
5. stop spellcheck and see how many occurrences of the word are left in the text






Actual Results:
N-1 unreplaced words are in the text

Expected Results:
0 words unreplaced


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.1.2.2 / LibreOffice Community
Build ID: 8a45595d069ef5570103caea1b71cc9d82b2aae4
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; VCL: osx
Locale: en-GB (de.UTF-8); UI: de-DE
Calc: threaded
Comment 1 birnbach@posteo.de 2021-07-07 10:05:55 UTC
Created attachment 173409 [details]
blind text with 26 occurrences of the word Lorem
Comment 2 birnbach@posteo.de 2021-07-07 10:14:02 UTC
Could trace the problem back to LO 6.4:

Version: 6.4.7.2
Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
CPU threads: 4; OS: Mac OS X 10.11.6; UI render: default; VCL: osx; 
Locale: en-GB (de.UTF-8); UI-Language: en-US
Calc: threaded

And I just saw that the labels on the buttons in English are "correct" and "correct all".
Comment 3 Полякова Анна 2021-07-22 12:55:24 UTC
confirm in
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 0d4cbdbc9cd4ab06056cec66cffd292b41615b6e
CPU threads: 4; OS: Mac OS X 10.14.6; UI render: default; VCL: osx
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded

Steps 4: the labels on the buttons in English are "correct" and "correct all".
Comment 4 Luke Kendall 2021-09-04 14:01:09 UTC
This bug has existed for at least five years, probably longer.

Ignore all does not work, either.

The spellcheck function has been so severely broken now for at least a year that I often have to spellcheck with hunspell separately, outside LibreOffice.

It broke badly somewhere between one year and two years ago.

Most of the bugs in LO spellcheck are in the UI - there's probably a day or two worth of work needed just to report all the bugs. But I see many bugs are already reported: opened, many new, many unassigned.

One clue I can offer is that the number of problems you'll experience in trying to use Writer's spellcheck UI seems proportional to the number of spelling errors. E.g. if you use it to try to correct errors in text mixed in with a programming language (so you add local dictionary additions to allow all the program's 'words' to spellcheck the genuine text parts), you'll quickly discover bizarre behaviour and failures in the UI. (Look through the many reports of problems and you'll experience all those reported bugs and more.)
Comment 5 birnbach@posteo.de 2021-09-11 10:53:39 UTC
I see there are tons of issues with the LibreOffice UI. Many problems seem to related to the Mac (modifier buttons in Draw, printing, document handling). I am contemplating moving to FreeBSD just so I can stay with LibreOffice.

Does anyone know if spellchecking works better on other platforms?
Comment 6 Stéphane Guillou (stragu) 2024-06-08 13:33:16 UTC
I can reproduce this issue on Linux as well:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1f15d097cace14ca6e44e7652f460aa3fa7bd150
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

With this bug's attachment 173409 [details], I reproduce the issue as described, but please test also the following:

1. Add an extra "Lorem" at the beginning of the first paragraph, so the document starts with "Lorem Lorem ipsum"
2. Start spell checker
3. Click "Correct all"

Result: first two occurences of "Lorem" corrected.
And the exact same in OOo 3.3, so not a regression.

Can you please confirm that you see the same on macOS? Because that would make bug 161245 the exact same issue. (See bug 161245 comment 3.)
Comment 7 birnbach@posteo.de 2024-06-10 10:13:24 UTC
Sorry, I cannot confirm.

"Lorem Lorem Lorem" --(correct all)--> 
"Loren Loren Loren" (correct)

"Lorem Lorem ipsum [50 words more] Lorem" --(correct all)--> 
"Loren Loren ipsum [50 words] Lorem" (partially correct)

It seems like the "replace all" function starts off well and stops eventually.

I checked this with LO 7.5.7.1. To be sure I upgraded to 

Version: 7.6.7.2 (AARCH64) / LibreOffice Community
Build ID: dd47e4b30cb7dab30588d6c79c651f218165e3c5
CPU threads: 8; OS: Mac OS X 13.4; UI render: Skia/Metal; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

with the same result
Comment 8 Stéphane Guillou (stragu) 2024-06-11 02:25:37 UTC
(In reply to birnbach@posteo.de from comment #7)
> Sorry, I cannot confirm.
> 
> "Lorem Lorem Lorem" --(correct all)--> 
> "Loren Loren Loren" (correct)
> 
> "Lorem Lorem ipsum [50 words more] Lorem" --(correct all)--> 
> "Loren Loren ipsum [50 words] Lorem" (partially correct)
Thank you. This is exactly what I described in comment 6: "Correct all" corrects everything up to the next different misspelling.
Comment 9 Stéphane Guillou (stragu) 2024-06-11 03:26:04 UTC
Marking as duplicate, see bug 91151 comment 3.

*** This bug has been marked as a duplicate of bug 91151 ***