Bug 143244 - Redo of adding table rows breaks table style after cut/paste action
Summary: Redo of adding table rows breaks table style after cut/paste action
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Balázs Sántha
URL:
Whiteboard: target:7.3.0 target:7.2.1
Keywords:
: 132743 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-07-07 17:34 UTC by Telesto
Modified: 2021-10-27 06:18 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (9.60 KB, application/vnd.oasis.opendocument.text)
2021-07-07 17:34 UTC, Telesto
Details
video about the steps (587.84 KB, video/mp4)
2021-07-08 08:06 UTC, Balázs Sántha
Details
Screencast (489.78 KB, video/mp4)
2021-07-08 13:42 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-07-07 17:34:20 UTC
Description:
Redo of adding table rows breaks table style after cut/paste action

Steps to Reproduce:
1. Open the attached file
2. CTRL+A
3. CTRL+X
4. CTRL+V
5. Place cursor in bottom row and press TAB (table is growing; with proper style, OK)
6. Press CTRL+Z until table gets deleted (CTRL+X)
7. CTRL+Y



Actual Results:
Notice the new rows becoming green

Expected Results:
Still matching style




Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: bd2f2273d83dcca43eb6b465308707efd45e7adf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

More broken in 7.1. Assuming recent fix improved things, but this still being present

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ec277dfdda8acd08694b03a6b1fb88c5fede35d2
Comment 1 Telesto 2021-07-07 17:34:37 UTC
Created attachment 173424 [details]
Example file
Comment 2 Telesto 2021-07-07 17:36:21 UTC
@Santha
You might be interested in this one
Comment 3 Balázs Sántha 2021-07-08 07:58:26 UTC
(In reply to Telesto from comment #2)
> @Santha
> You might be interested in this one

@Telesto
Thanks for the suggestion! 
I haven't been able to reproduce this bug. I made a video about this, but seems good to me.
Comment 4 Balázs Sántha 2021-07-08 08:06:37 UTC
Created attachment 173441 [details]
video about the steps
Comment 5 Telesto 2021-07-08 13:42:17 UTC
Created attachment 173456 [details]
Screencast
Comment 6 Balázs Sántha 2021-07-22 12:34:09 UTC
@Telesto
Thanks for the video. I made a patch about this, which seem to fix this. Would you mind to test it?
https://gerrit.libreoffice.org/c/core/+/119249
Comment 7 Commit Notification 2021-07-22 14:35:57 UTC
Balazs Santha committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/689b5a4862ead541e54e83cb14067cfaa691e2ab

tdf#143244 sw: fix redo of adding table rows breaks table style

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Buovjaga 2021-07-22 17:31:31 UTC
*** Bug 132743 has been marked as a duplicate of this bug. ***
Comment 9 BogdanB 2021-07-23 19:17:47 UTC
Balazs Santha, please mark this bug as resolved. I have verified and it is ok now. Thanks for your work.

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 612d5b1a04fe022a34018d901bb9b052791d54e5
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 10 Commit Notification 2021-08-12 15:55:30 UTC
Balazs Santha committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/53902e2ecf8ab1bb3f1cfa203de105d6d956e7ef

tdf#143244 sw: fix redo of adding table rows breaks table style

It will be available in 7.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-10-27 06:18:59 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5b7e88d007173e9567299226371a8efda23e7dd9

tdf#143244: sw: move UItest to CppUnittest

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.