Bug 143315 - FILESAVE: PPTX: Bullet added to WordArt in MSO after RT
Summary: FILESAVE: PPTX: Bullet added to WordArt in MSO after RT
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0 target:7.2.0.2
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2021-07-12 13:58 UTC by Xisco Faulí
Modified: 2021-10-19 07:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison LibreOffice 7.3 master and MSO 2010 (55.44 KB, image/png)
2021-07-12 13:58 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-07-12 13:58:44 UTC
Created attachment 173508 [details]
Comparison LibreOffice 7.3 master and  MSO 2010

Steps to reproduce:
1. Open attachment 97699 [details] from bug 77741
2. Save it as PPTX
3. Open it in Microsoft Office ( I'm using 2010 )

-> The wordart has a bullet. See screenshot

Reproduced in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 61618141f0204ce6653354f6424e11276d939aed
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2021-07-12 13:59:46 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c4f615b359be56e88e4fbf9aaaf30affb29d57e2

author	Mike Kaganski <mike.kaganski@collabora.com>	2021-05-23 15:40:08 +0300
committer	Mike Kaganski <mike.kaganski@collabora.com>	2021-06-08 14:50:33 +0200
commit c4f615b359be56e88e4fbf9aaaf30affb29d57e2 (patch)
tree 484f1caaf27bc3cefc0d1a7e0614342927117440
parent 064a13e94e9b38bc88381b5c497cf6c9ddbe93e4 (diff)
editengine-columns: Create document model and dialog page

Bisected with: bibisect-linux64-7.3

Adding Cc: to Mike Kaganski
Comment 2 Xisco Faulí 2021-07-12 14:06:23 UTC
attachment 102670 [details] from bug 81265 is also affected by this issue
Comment 3 Mike Kaganski 2021-07-12 14:59:09 UTC
(In reply to Xisco Faulí from comment #1)
> Regression introduced by:
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=c4f615b359be56e88e4fbf9aaaf30affb29d57e2

Highly unlikely. The mentioned commit does not change import or export; the affected markup (a:pPr) is also unrelated to the change...

Then why bibisect-linux64-7.3? The suspect commit was before 7-2 branch-off.

I will try bibisect locally on Windows :)
Comment 4 Mike Kaganski 2021-07-12 19:07:36 UTC
(In reply to Mike Kaganski from comment #3)
> Highly unlikely.
> ...
> I will try bibisect locally on Windows :)

And I confirm your bibisection results :)
Comment 5 Commit Notification 2021-07-14 23:25:31 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/717dc8e3575a18e1e18dc446031e6db4e60a873d

tdf#143315: restore the stylesheet after clearing outliner object

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Mike Kaganski 2021-07-15 07:01:23 UTC
FTR: this was not a true regression (and that's why I was confused initially): this was just a smelling code dependent on a fragile unspecified and unreliable implementation detail, which got uncovered when the detail had changed by the said commit.
Comment 7 Commit Notification 2021-07-15 07:04:13 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/b3d2abf4c113741a386b7eb840e22b872f29c7c3

tdf#143315: restore the stylesheet after clearing outliner object

It will be available in 7.2.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Xisco Faulí 2021-07-15 07:58:50 UTC
Let's remove the 'regression' keyword then