Bug 143316 - FILESAVE: PPTX: Time field disappears in MSO after RT
Summary: FILESAVE: PPTX: Time field disappears in MSO after RT
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Sarper Akdemir (allotropia)
URL:
Whiteboard: target:7.3.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2021-07-12 14:14 UTC by Xisco Faulí
Modified: 2021-11-22 18:21 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
sample file (34.44 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2021-07-12 14:14 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2021-07-12 14:14:23 UTC
Created attachment 173509 [details]
sample file

Steps to reproduce:
1. Open attached document
2. Save it as PPTX
3. Open it MSO Power Point ( In my case I'm using 2010 )

-> The time field is gone

Reproduced in

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 61618141f0204ce6653354f6424e11276d939aed
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2021-07-12 14:16:08 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=166671f4aa19deec47c10a220ae1d29fa57faa93

author	Sarper Akdemir <sarper.akdemir@collabora.com>	2021-04-25 15:59:39 +0300
committer	Miklos Vajna <vmiklos@collabora.com>	2021-06-16 14:32:41 +0200
commit 166671f4aa19deec47c10a220ae1d29fa57faa93 (patch)
tree 58d54267c405ae50e66f452d52dd074d561606ef
parent 3c46fd3d727e4885fedef7c9f3fcd6f4c9a9ebb9 (diff)
tdf#59323: pptx import: import footer fields as properties

Bisected with: bibisect-linux64-7.3

Adding Cc: to Sarper Akdemir
Comment 2 Sarper Akdemir (allotropia) 2021-07-12 14:42:14 UTC
Hello Xisco,

There was a similar regression with LO versions before 166671f4aa19deec47c10a220ae1d29fa57faa93
(tdf#59323: pptx import: import footer fields as properties)

And I've sent a patch that fixes that at
https://gerrit.libreoffice.org/c/core/+/118008

I do not have access to MSO 2010 right now, but I wasn't able to reproduce this with MSO 2019.

Could you see if that patch fixes this regression too, please? :)
I'm cc'ing you there.
Comment 3 Xisco Faulí 2021-07-12 15:26:10 UTC
(In reply to Sarper Akdemir from comment #2)
> Hello Xisco,
> 
> There was a similar regression with LO versions before
> 166671f4aa19deec47c10a220ae1d29fa57faa93
> (tdf#59323: pptx import: import footer fields as properties)
> 
> And I've sent a patch that fixes that at
> https://gerrit.libreoffice.org/c/core/+/118008
> 
> I do not have access to MSO 2010 right now, but I wasn't able to reproduce
> this with MSO 2019.
> 
> Could you see if that patch fixes this regression too, please? :)
> I'm cc'ing you there.

Hello Sarper,
With your patch, MSO Powerpoint 2010 shows 'Date' instead of the time like '5:25:31 PM' which was displayed before 166671f4aa19deec47c10a220ae1d29fa57faa93
Comment 4 Sarper Akdemir (allotropia) 2021-07-12 15:45:04 UTC
(In reply to Xisco Faulí from comment #3)
> With your patch, MSO Powerpoint 2010 shows 'Date' instead of the time like
> '5:25:31 PM' which was displayed before
> 166671f4aa19deec47c10a220ae1d29fa57faa93

Oh, I see - Will get my hands on to MSO Powerpoint 2010 and look into this, thank you for testing the patch :)
Comment 5 Commit Notification 2021-11-22 13:06:47 UTC
Sarper Akdemir committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d3651f96d45405d6d142bf97084c377e395945c3

tdf#143316: fix datetime footer regression on mso2010

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-11-22 18:20:21 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5a00326951690d820d8ea5412a93aadf3da42dc1

tdf#143316: sd_export_tests-ooxml2: Add unittest

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2021-11-22 18:21:11 UTC
Closing as VERIFIED FIXED

@Sarper Akdemir, thanks for fixing this issue!!