Bug 143568 - Impress: Redo cut off
Summary: Impress: Redo cut off
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisectRequest, regression
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2021-07-28 01:53 UTC by Telesto
Modified: 2025-05-17 08:18 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example file (14.32 KB, application/vnd.oasis.opendocument.presentation)
2021-07-28 01:54 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-07-28 01:53:50 UTC
Description:
Impress: Redo cut off

Steps to Reproduce:
1. Open the attached file
2. Click "Click to add title' on sheet one
3. Type A
4. Go to sheet 2
5. Click the 'Click to add text box'
6. Type B
7. Press CTRL+Z 2x (so with focus in still inside bulleted list textbox)
8. Press CTRL+Y

Actual Results:
No Redo

Expected Results:
Should be the case, IMHO


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2a151d1d5bc055d5e0011460b6ec42ea9f34f880
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-07-28 01:54:11 UTC
Created attachment 173891 [details]
Example file
Comment 2 Telesto 2021-07-28 01:58:29 UTC
Also in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL


not in
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28

[The difference is that 2x undo doesn't work here]. Focus kept inside bulleted list textbox]. You need to leave the textbox.. to undo things on other sheets..

Which seems pretty decent workflow..
Comment 3 BogdanB 2021-07-28 05:48:19 UTC
Confirm with
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 612d5b1a04fe022a34018d901bb9b052791d54e5
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 4 QA Administrators 2025-05-17 03:12:13 UTC Comment hidden (obsolete)
Comment 5 Saburo 2025-05-17 08:18:25 UTC
I think this commit fixed it.
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c175c1dc19d0edc8ca66e39f0b4b8af04e3d6c87
svx: Don't end text edit mode for all views
This allows multiple views to not disturb each other editing inside
a impress document. With the ending of text edit for all views still
enabled, one view can cancel other views text editing just by moving
or resizing a unrelated shape in the document.

To make this possible we also need a view-local undo manager for
the text edit mode, which is independent of the document undo
manager. When the text edit mode ends, all the changes will be
added as one change to the document undo stack. This prevents any
conflicts in the undo stack that could be made when 2 views are
editing the same document at the same time.

This also adds the test for the new use case and changes the existing
tests to reflect the change.

Change-Id: I04edb4f91d7e111a490c946f7121cbca75f818d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123220