Bug 143587 - Latest *Dev Release appears to magnify autofilter buttons
Summary: Latest *Dev Release appears to magnify autofilter buttons
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks: AutoFilter
  Show dependency treegraph
 
Reported: 2021-07-28 15:10 UTC by Colin
Modified: 2023-08-01 06:41 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screen image (29.43 KB, image/png)
2021-07-28 15:11 UTC, Colin
Details
minimal reproducer autofilter (7.64 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-07-28 19:45 UTC, Gabor Kelemen (allotropia)
Details
af buttons on linux, master/7.3 (9.96 KB, image/png)
2021-07-29 07:09 UTC, Szymon Kłos
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Colin 2021-07-28 15:10:58 UTC
Description:
See attached image.
The original file in the user environment has all the autofilter buttons scaled to fit the cell height - this occurred automatically when the filters were created.
Also note that my document has column & Row freeze active on line 5
The dev version 
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 67f2a99229101757af4f40118f4d3c83ba38648b
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded
works as expected until the sheet zoom factor goes beyond 100 then the button grows beyond the height of the cell.

This doesn't occur with release 7.0.6.2

Steps to Reproduce:
Set zoom to 100%
on line 5 create an array of say ten columns with random headers
set this array as autofiltered
Optionally add some random data to a few lines beneath the headers
Optionally add some random data to the lines above the headers
Set a column and row freeze to allow the table to scroll under the headers
magnify the screen either with  ctrl+scroll wheel or the scale control at bottom right of the sheet
observe how the auto filer buttons will grow beyon the vertical limit of the row

Actual Results:
Button Grows disproportionately

Expected Results:
Button not to grow disproportionately


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 67f2a99229101757af4f40118f4d3c83ba38648b
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

New Testing installation and new profile
Comment 1 Colin 2021-07-28 15:11:56 UTC
Created attachment 173921 [details]
screen image
Comment 2 Gabor Kelemen (allotropia) 2021-07-28 19:45:07 UTC
Created attachment 173934 [details]
minimal reproducer autofilter

Confirming the behavior in:

Version: 7.2.0.1.0+ / LibreOffice Community
Build ID: 2a265bdda19d86437c6eb4d8deb0057d5b45e97f
CPU threads: 2; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 3 Gabor Kelemen (allotropia) 2021-07-28 21:02:55 UTC
Bibisected with linux-72 to :

https://cgit.freedesktop.org/libreoffice/core/commit/?id=008c2354075e1b5b63000f6a2da802971a2902e6

author	Szymon Kłos <szymon.klos@collabora.com>	2021-02-01 16:48:28 +0100
committer	Szymon Kłos <szymon.klos@collabora.com>	2021-03-04 15:42:21 +0100

autofilter: scale dropdown button according to zoom level

With this increasing the zoom level above 120% (or so) makes the dropdown taller than the cell itself.

Before this increasing the zoom level made the dropdown shorter than the cell itself. So it was not that good either.

Adding CC to: Szymon Kłos
Comment 4 Szymon Kłos 2021-07-29 07:09:26 UTC
Created attachment 173938 [details]
af buttons on linux, master/7.3

For me on linux with master it works correctly, both on gtk3 and vclplugin=gen

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 8ae8d522b102fdea1a4143e943b9c477be5bb3cc
CPU threads: 16; OS: Linux 4.12; UI render: default; VCL: gtk3
Locale: pl-PL (pl_PL.utf8); UI: en-US
Calc: threaded

Issue is windows only? I don't have a windows environment to fix that quickly unfortunately
Comment 5 Gabor Kelemen (allotropia) 2021-07-29 11:35:18 UTC
No, it happens on Linux as well.

Looking better at it, I have changed in gnome-tweaks under the Fonts tab the Scaling factor setting, from the default 1 to 0.8 so my screen shows smaller fonts and more letters at the same time.

With the default value of this setting Calc draws the button correctly.
Comment 6 Aron Budea 2021-07-30 20:55:53 UTC
Not sure if it's the same thing, but using various SAL_FORCEDPI environment variables can show something similar.

Eg. SAL_FORCEDPI=60, at 140% zoom is very visibly larger, while with SAL_FORCEDPI=140, at 100% zoom it's already noticeably smaller than the cell height.
Comment 7 QA Administrators 2023-07-31 03:05:33 UTC Comment hidden (obsolete)
Comment 8 Colin 2023-08-01 06:41:48 UTC
Version: 7.4.7.2 (x64) / LibreOffice Community
Build ID: 723314e595e8007d3cf785c16538505a1c878ca5
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: sv-SE (en_GB); UI: en-GB
Calc: threaded

Resolved