Bug 143619 - EDITING Validation circles move left/up on deleting a column/row
Summary: EDITING Validation circles move left/up on deleting a column/row
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.3 release
Hardware: All All
: medium normal
Assignee: Regina Henschel
URL:
Whiteboard: target:7.3.0 target:7.2.1 target:7.1.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Cell-Validity
  Show dependency treegraph
 
Reported: 2021-07-30 07:59 UTC by NISZ LibreOffice Team
Modified: 2021-08-18 17:43 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Calc (13.97 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-07-30 07:59 UTC, NISZ LibreOffice Team
Details
The file before any changes (39.87 KB, image/png)
2021-07-30 07:59 UTC, NISZ LibreOffice Team
Details
Screenshot of the problem in Calc after deleting a column (28.89 KB, image/png)
2021-07-30 08:00 UTC, NISZ LibreOffice Team
Details
Screenshot of the problem in Calc after deleting a row (37.12 KB, image/png)
2021-07-30 08:00 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-07-30 07:59:30 UTC
Created attachment 173962 [details]
Example file from Calc

Attached example file contains a few validated cells with invalid values circled.
When a row or column is deleted from the sheet the validation circles move one column to the left and one row up.

Steps to reproduce:
    1. Open attached document
    2. Delete row 1 or Column A

Actual results:
All validation circles move one column to the left and one row up.

Expected results:
Validation circles stay with their cells.

LibreOffice details:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ac80ec817eb07c77a51bc0729985a473c734182e
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Not yet in 7.0

Additional Information:
Bibisected using bibisect-win64-7.1 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=2383bb3dfe489309b1b57b95bfec56b4967610fb 
author	Regina Henschel <rb.henschel@t-online.de>	2021-01-15 17:40:10 +0100
committer	Xisco Fauli <xiscofauli@libreoffice.org>	2021-01-19 11:45:18 +0100

tdf#139583 fix case rot 180deg for cell anchored shapes

(double verified with git checkout HEAD~1)

Adding CC to:  Regina Henschel
Comment 1 NISZ LibreOffice Team 2021-07-30 07:59:50 UTC
Created attachment 173963 [details]
The file before any changes
Comment 2 NISZ LibreOffice Team 2021-07-30 08:00:07 UTC
Created attachment 173964 [details]
Screenshot of the problem in Calc after deleting a column
Comment 3 NISZ LibreOffice Team 2021-07-30 08:00:23 UTC
Created attachment 173965 [details]
Screenshot of the problem in Calc after deleting a row
Comment 4 Regina Henschel 2021-07-30 13:13:51 UTC
The problem exists as described.
Comment 5 Regina Henschel 2021-07-30 21:34:32 UTC
Same for insert row/col.

Proposed patch is in https://gerrit.libreoffice.org/c/core/+/119715
Comment 6 Commit Notification 2021-08-02 17:23:14 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0cff1aa48453ee0c05bafcac5360329fb6bf9557

tdf#143619 validation circle anchor is special

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 NISZ LibreOffice Team 2021-08-05 12:40:09 UTC
Verified in: 

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ad1b12686da88bea57582df10fa85268ada209b8
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded
Comment 8 Commit Notification 2021-08-09 17:44:06 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/a1791f7e2503ca1d0868a0a607ff4717cd1fddeb

tdf#143619 validation circle anchor is special

It will be available in 7.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2021-08-18 17:43:42 UTC
Regina Henschel committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/ee749af6d3c742efdfc28d245db6422d461ed51b

tdf#143619 validation circle anchor is special

It will be available in 7.1.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.