Bug 143668 - Clicking spellcheck in Impress (temporarily) activates master handouts view (although it contains no spelling errors)
Summary: Clicking spellcheck in Impress (temporarily) activates master handouts view (...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: lowest trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, regression
Depends on:
Blocks: Spell-Checking-Dialog
  Show dependency treegraph
 
Reported: 2021-08-01 10:42 UTC by Telesto
Modified: 2025-10-08 13:59 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (10.71 KB, application/vnd.oasis.opendocument.presentation)
2021-08-01 10:43 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-08-01 10:42:44 UTC
Description:
Clicking spellcheck in Impress activates master handouts view for some reason

Steps to Reproduce:
1. Open the attached file
2. Press the ABC V button in the toolbar (spell checker)


Actual Results:
Master hands out view while spell check dialog open

Expected Results:
Not so.. 


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 2a151d1d5bc055d5e0011460b6ec42ea9f34f880
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
4.4.7.2

and in
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28

less obvious in 3.5.7.2 (flashes to Master Handout and back)

not noticing anything with 3.0 (or goes to fast)
Comment 1 Telesto 2021-08-01 10:43:02 UTC
Created attachment 174010 [details]
Example file
Comment 2 Dmitrii A 2021-08-02 04:53:03 UTC
No repro in

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: ac80ec817eb07c77a51bc0729985a473c734182e
CPU threads: 16; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL
Comment 3 yellowplane 2021-08-09 14:48:30 UTC
I can reproduce in

Version: 7.3.0.0.alpha0+ (x86) / LibreOffice Community
Build ID: ad1b12686da88bea57582df10fa85268ada209b8
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_US); UI: en-US
Calc: threaded

Master Handout View is only visible in the background when the following dialogue boxes are open:

"LibreOfficeDev Impress has searched to the end of the presentation. Do you want to continue at the beginning?  >Yes/No"

and

"Spellcheck of entire document has been completed. >OK"

When I click out of these dialogue boxes, the Master Handout view goes away again.
Comment 4 raal 2021-10-02 18:05:17 UTC
Repro with x11, but not with GTK3

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: b63c5ade3554a42def4bce94f9fd67ea66528214
CPU threads: 4; OS: Linux 5.11; UI render: default; VCL: x11
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded
Comment 5 QA Administrators 2024-12-21 03:12:57 UTC Comment hidden (obsolete)
Comment 6 Telesto 2024-12-21 04:24:25 UTC
Still present
Version: 25.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 5e0c670e6534fee529ea46d520c6b442bea93aac
CPU threads: 8; OS: macOS 14.7.1; UI render: Skia/Metal; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded
Comment 7 Buovjaga 2025-09-21 14:29:09 UTC
On Linux, the behaviour changed with commit cf523a77a76645f301aaa43b57b0c78c8c685561
tdf#166964 Switch to IconView in LayoutMenu for improved UI handling

Now there is only a brief flash of the view when starting Spelling. Maybe it tries to switch to the handout view, but for some reason the change gets suppressed. Now I notice that this is kind of in line with what comment 0 says: "less obvious in 3.5.7.2 (flashes to Master Handout and back)".

On Windows the behaviour was not changed.

Testing with latest is at the moment blocked by bug 168500

Bibisected the original change with linux-43all to range https://cgit.freedesktop.org/libreoffice/core/log/?id=043273e721ade64e4fb42f969cf22b4202c6b80d&qt=range&q=a1ac2538e9b287444500618ab4d2f0f06c25cf34..19f4ebd8a54da0ae03b9cc8481613e5cd20ee1e7
Comment 8 Justin L 2025-10-02 22:23:30 UTC
The spell check is going to check all "things" and this includes the notes and handouts. I assume that the handout view is the last one checked.

Since there are no misspellings in this document, going through the context-switching could be avoided.
Comment 9 Justin L 2025-10-08 13:59:46 UTC
Despite SdOutliner::EndOfSearch having the comment 
    // Before we display a dialog we first jump to where the last valid text
    // object was found.  All page and view mode switching since then was
    // temporary and should not be visible to the user.
disabling that had no effect. [And it sounded so promising...]

At the very end (SdOutliner::EndSpelling), everything is restored with SdOutliner::RestoreStartPosition.

However, everything works differently when I step through the code in GDB. So the screen painting must be happening in an idle loop or something. I'm not going to look at this further. Editeng stuff is just bizarre, feels completely unstable and fragile and unoptimized, and basically just incomprehensible. Any attempt to change anything is a disaster in the making.