Bug 143704 - Locked Standard toolbar can still be undocked, hides behind Formatting toolbar
Summary: Locked Standard toolbar can still be undocked, hides behind Formatting toolbar
Status: RESOLVED DUPLICATE of bug 139259
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.6.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Toolbars
  Show dependency treegraph
 
Reported: 2021-08-03 12:36 UTC by Stéphane Guillou (stragu)
Modified: 2023-09-11 13:24 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot of superimposed toolbars (29.91 KB, image/png)
2021-08-03 12:44 UTC, Stéphane Guillou (stragu)
Details
screenshot of superimposed toolbars (LO 7.0.6) (32.42 KB, image/png)
2021-08-03 12:47 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Guillou (stragu) 2021-08-03 12:36:54 UTC
Description:
Even though locked toolbars shouldn't be undockable, it is possible to undock the Standard toolbar (which is locked by default).
Doing so results in the toolbar "hiding" behind the Formatting toolbar, and makes it impossible to move it.

Steps to Reproduce:
1. Open Writer
2. Right-click on Standard toolbar
3. Confirm that it is locked (the default)
4. Click on "Undock Toolbar"

Actual Results:
Toolbar is undocked and the icons appear below the Formatting toolbar.

Expected Results:
It shouldn't be possible to undock the toolbar, and if it is indeed undocked after unlocking, it shouldn't be hidden behind another toolbar.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Restarting the module will show the standard toolbar undocked and movable (i.e. not hidden behind the Formatting toolbar anymore).

The bug does not happen when you unlock the toolbar before undocking it.

Seen in:

Version: 7.0.6.2
Build ID: 00(Build:2)
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Ubuntu package version: 1:7.0.6-0ubuntu0.20.04.1_lo1
Calc: threaded

and:

Version: 7.2.0.2 / LibreOffice Community
Build ID: 614be4f5c67816389257027dc5e56c801a547089
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and:

Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 1dd4a80fa076bedb3a82821517036bad8dd79857
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2021-07-26_22:41:19
Calc: threaded
Comment 1 Buovjaga 2021-08-03 12:38:38 UTC
Same commit as bug 143688, so closing as dupe

*** This bug has been marked as a duplicate of bug 143688 ***
Comment 2 Stéphane Guillou (stragu) 2021-08-03 12:43:04 UTC
Buovjaga, setting back to UNCONFIRMED as I don't agree with the duplicate you propose.
This is not a regression as far as I can tell, and was already an issue in 7.0.6 (I forgot to change the earliest version to that one).
Comment 3 Stéphane Guillou (stragu) 2021-08-03 12:44:20 UTC
Created attachment 174043 [details]
screenshot of superimposed toolbars

Screenshot of the Standard toolbar hidden behind the Formatting toolbar in Writer, LO 7.3 alpha0+
Comment 4 Stéphane Guillou (stragu) 2021-08-03 12:47:43 UTC
Created attachment 174045 [details]
screenshot of superimposed toolbars (LO 7.0.6)

Same thing, in LO 7.0.6.
Comment 5 Buovjaga 2021-08-03 13:54:17 UTC
Sorry, but you don't understand:
1. It is wrong to add Diwanshu to this as he has nothing to do with this
2. It is a regression caused by Heiko's commit

If you don't believe me, run a build from the time between 2f13fcb67269f99b890f5bb4c63117805e375692 and 086fa727cabf46eacfec1a0fd4f6dfe916aa2f04

*** This bug has been marked as a duplicate of bug 143688 ***
Comment 6 Heiko Tietze 2021-08-19 08:07:23 UTC
Bug 143688 is about floating widgets while this one talks about the whole toolbar. I can confirm the issue and suggested solution is to disable toolbar when locked, done in bug 131441.

The issue is starts after docking the toolbars by default but it would be the same when done manually.

*** This bug has been marked as a duplicate of bug 131441 ***
Comment 7 Stéphane Guillou (stragu) 2021-08-20 12:31:43 UTC
Thank you Heiko and Buovjaga.

Just to clarify: Heiko, you can also see the toolbar overlapping issue?
Bug 131441 is marked as FIXED, but I can still reproduce the issue described here with 7.2 release:

Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I did another search with different keywords, and it looks like the overlapping issue might be a duplicate of Bug 139259. I believe this bug should be marked as a duplicate of that one.

Regarding the issue with the ability of undocking a locked toolbar (i.e. the "resuscitation" of Bug 131441), which bug is it if it is not Bug 143688 ? Do we need to open a new one?
Comment 8 Buovjaga 2021-08-20 12:53:38 UTC
(In reply to stragu from comment #7)
> Regarding the issue with the ability of undocking a locked toolbar (i.e. the
> "resuscitation" of Bug 131441), which bug is it if it is not Bug 143688 ? Do
> we need to open a new one?

Yep, this was bisected by me to the same commit blamed for bug bug 143688. If there is a desire to close something as dupe, then let's target 139259 that you found.

*** This bug has been marked as a duplicate of bug 139259 ***
Comment 9 Heiko Tietze 2021-08-23 07:43:11 UTC
Bug 143688 is about floating widgets like Shapes - you can detach this widgets and keep as kind of toolbar (TB). Now _all_ TB are docked/undocked as a consequence of the new command View > Toolbars > Docked, that intends to resolves complaints about docked TBs, which we docked by default to avoid unintentional undocking. Solution for 143688 is to somehow check if the TB belongs to a widget.

Bug 139259 would be an issue anyway, whether TB are docked automatically or manually. TBs must not merge with other under no circumstances.