Created attachment 174065 [details] The dialog in Writer with default size The Styles frame contents of the Assign Styles dialog does not resize when the dialog is resized. Steps to reproduce: 1. Open attachment 138328 [details] from bug 114363 this illustrates the use case better 2. Right click the TOC on the second page, choose Edit Index 3. In the Table of Contents dialog press the Assign styles button 4. Notice with this file there are lots of styles listed and scroll bars appear inside the dialog 5. Resize the dialog Actual results: The Styles frame is not resized, the enlarged part of the dialog is empty. Expected results: The Styles frame should fill the dialog and show more styles so the user don’t need the scrollbars. LibreOffice details: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 7c38362dbe1922c9825dffb463072030948d406b CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: en-US (hu_HU); UI: en-US Calc: CL Not yet in 6.1. Additional Information: Bibisected using bibisect-win32-6.3 to: URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=6236051a3496278fe2768b40ebf1f4e82a44bb44 author Caolán McNamara <caolanm@redhat.com> 2018-12-10 11:32:51 +0000 committer Caolán McNamara <caolanm@redhat.com> 2018-12-12 13:01:28 +0100 weld SwAddStylesDlg Adding CC to: Caolán McNamara Note: On Linux this does not happen with GTK backend, but it does with gen.
Created attachment 174066 [details] The dialog after resizing
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4e7212c4a341eef0521c4c6300c65bf42d756fd1 Resolves: tdf#143720 treeview not resizing to fill available space It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
backports to 7-2 and 7-1 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/660a8eae3c5d92f08bf72342f41fd97249099ab5 Resolves: tdf#143720 treeview not resizing to fill available space It will be available in 7.1.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/9cf27e924aaea4d45c059edec07be1429cbb16d4 Resolves: tdf#143720 treeview not resizing to fill available space It will be available in 7.2.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
After the patch the styles frame fill the dialog horizontally, but vertically still not resized, the enlarged part of the dialog vertically is still empty. In version: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: threaded Dear Caolán McNamara! Reopen or have a new ticket?
Created attachment 175560 [details] Screenshot of the problem in Writer
Regression introduce by: weld SwAddStylesDlg https://cgit.freedesktop.org/libreoffice/core/commit/?id=3b0b390bab5f6e58492363adda891cdfb6774eea author Caolán McNamara <caolanm@redhat.com> 2018-12-10 11:32:51 +0000 committer Caolán McNamara <caolanm@redhat.com> 2018-12-12 17:05:07 +0100 bibisect with: win32-6.2
seems to be ok under gtk but some quirk of the treeview with headers under gen, using a box in this case instead of a grid is sufficient
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/517e07bbcf668e1ea58dabeb35c0fb467b36ed05 tdf#143720 treeview not expanding vertically to fill space It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
take two now in trunk, backport to 7-4 in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/8f99fe30d0661e278824b2f8f65aaa5f94a622ac tdf#143720 treeview not expanding vertically to fill space It will be available in 7.3.4. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: cdf8e971d5d46df4bcab35a99c4254df9459213f CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL