Bug 143886 - Consider removing Attribute Blinking in Find and Replace dialog
Summary: Consider removing Attribute Blinking in Find and Replace dialog
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
(earliest affected) release
Hardware: All All
: low enhancement
Assignee: Not Assigned
Depends on:
Blocks: Infobar Find&Replace-Dialog
  Show dependency treegraph
Reported: 2021-08-15 09:10 UTC by lol
Modified: 2022-12-01 13:49 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Note You need to log in before you can comment on or make changes to this bug.
Description lol 2021-08-15 09:10:50 UTC
In Writer - Edit - Find and Replace... you can choose in the dialog Attributes the attribute "blinking". Blinking has been removed since LO 7.0.

Steps to Reproduce:
1. Open a new document Writer
2. Choose Edit - Find and Replace...
3. Click on the button Attributes...

Actual Results:
The attribute "blinking" is available.

Expected Results:
The attribute "blinking" should not be available.

Reproducible: Always

User Profile Reset: No

Additional Info:
Version: (x64) / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 1 [REDACTED] 2021-08-16 08:18:02 UTC
From a short test and just to mention a side effect:

Blinking attribute seems to keep present, if it has been added to documents using a version < 7.0. It does not vanish, if you save such document using LibreOffice >= 7.0 (though the blinking effect is not shown in such versions). In consequence: If you remove the option to Find and Replace "[x] Blinking", users will be forced to use a version less than 7 to change old existing document for the sake of removing "Blinking".

(This is not a vote against such change, but a comment about the side effect, which need to be handled, e.g. by silently removing such attribute, when docs are saved using a new version of LibreOffice).
Comment 2 lol 2021-10-16 14:25:46 UTC
Yes, you are right. Blinking attributes are present in LO => 7. You can find them.

Now the question is: Is that still needed?
Comment 3 Buovjaga 2022-11-23 12:02:48 UTC
(In reply to lol from comment #2)
> Yes, you are right. Blinking attributes are present in LO => 7. You can find
> them.
> Now the question is: Is that still needed?

UX team: maybe this attribute was used so rarely that it is not a big deal to remove the entry from Find & Replace?
Comment 4 Eike Rathke 2022-11-23 15:23:42 UTC
Even if Blinking was removed, or even more then, the option to replace Blinking should stay as someone may want to use another visual indicator instead.
Comment 5 Heiko Tietze 2022-11-24 15:08:43 UTC
The blinking attribute was removed from the UI for bug 132373. But the ODF attribute still exits for legacy documents, and the idea to remove the control was challenged back then since users cannot switch it off anymore. So taking Eike's comment 4 to resolve this as WF/NAB.
Comment 6 Mike Kaganski 2022-11-25 08:42:48 UTC
Personally I'd say: yes, remove the thing from UI; and introduce a check on import, which would show an infobar with "this document has a deprecated Blinking effect; press this button to clear it from the file".

I don't think that having it in the UI as it is now makes sense for an extremely rare case of such a document; having a dedicated always-shown UI for 0.00...1% is IMO a bad UX.
Comment 7 Heiko Tietze 2022-12-01 13:49:35 UTC
Some acceptance for Mike's idea, let's do it and show an infobar if the text contains blinking text with the ability to turn it off. And drop the attribute from the F&R dialog.