Bug 143929 - FILESAVE ODS Two column shape setting not saved
Summary: FILESAVE ODS Two column shape setting not saved
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.0.0 alpha1+
Hardware: All All
: medium normal
Assignee: Mike Kaganski
URL:
Whiteboard: target:7.3.0 target:7.2.1
Keywords: filter:ods
Depends on:
Blocks: Shapes
  Show dependency treegraph
 
Reported: 2021-08-18 07:32 UTC by NISZ LibreOffice Team
Modified: 2021-10-06 09:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Calc with shape containing text (13.07 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-08-18 07:32 UTC, NISZ LibreOffice Team
Details
The original file saved by Calc to XLSX (5.82 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2021-08-18 07:32 UTC, NISZ LibreOffice Team
Details
The shape with two columns and spacing set before reloading (47.90 KB, image/png)
2021-08-18 07:33 UTC, NISZ LibreOffice Team
Details
The ODS and XLSX files after reloading in Calc (67.66 KB, image/png)
2021-08-18 07:33 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-08-18 07:32:25 UTC
Created attachment 174362 [details]
Example file from Calc with shape containing text

Attached document contains a shape with text that was set to be two column with 1 cm spacing.
This setting is not saved (or loaded?) correctly to ODS format by Calc.
Saving to XLSX however works fine, even in Excel the shape appears as intended.

Steps to reproduce:
    1. Open attached file
    2. Select the shape, choose Format – Object – Text
    3. On the Text Columns tab set more than one columns and some spacing
    4. Save as ODS, reload

Actual results:
The shape has 1 column, 0 spacing set.
Saving to XLSX works fine.

Expected results:
The number of columns and spacing is retained on saving to ODS.

LibreOffice details:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dd3ab0fd737ff84657ff34eebafe2628f489e5a1
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 1 NISZ LibreOffice Team 2021-08-18 07:32:43 UTC
Created attachment 174363 [details]
The original file saved by Calc to XLSX
Comment 2 NISZ LibreOffice Team 2021-08-18 07:33:05 UTC
Created attachment 174364 [details]
The shape with two columns and spacing set before reloading
Comment 3 NISZ LibreOffice Team 2021-08-18 07:33:25 UTC
Created attachment 174365 [details]
The ODS and XLSX files after reloading in Calc
Comment 4 NISZ LibreOffice Team 2021-08-18 07:34:04 UTC
@Mike I thought you might be interested in this one
Comment 5 Henrik Palomäki 2021-08-19 16:33:54 UTC
Reproduced on 7.2.0.4 (x64)
Reproduced on 7.3.0.0.alpha0+ (x64)
Comment 6 Mike Kaganski 2021-08-25 11:29:27 UTC
https://gerrit.libreoffice.org/c/core/+/120958
Comment 7 Commit Notification 2021-08-25 17:20:49 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cfa931784082d38bb6b98058c5acccbaf9870710

tdf#143929: chain XMLTextExportPropertySetMapper to sc's shape export

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-08-26 07:29:52 UTC
Mike Kaganski committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/c8be3338287ba3bdb6af377d89939751cbb295b4

tdf#143929: chain XMLTextExportPropertySetMapper to sc's shape export

It will be available in 7.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 NISZ LibreOffice Team 2021-10-06 09:25:46 UTC
Verified in: 

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded