Bug 143938 - EDITING Change tracked character style change for entire paragraph does not store previous character style
Summary: EDITING Change tracked character style change for entire paragraph does not s...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.3.0
Keywords: implementationError
Depends on:
Blocks: Track-Changes-TextFormatting
  Show dependency treegraph
 
Reported: 2021-08-18 15:12 UTC by NISZ LibreOffice Team
Modified: 2021-09-03 08:37 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer (14.84 KB, application/vnd.oasis.opendocument.text)
2021-08-18 15:12 UTC, NISZ LibreOffice Team
Details
Screenshot of the original document in Writer (110.96 KB, image/png)
2021-08-18 15:12 UTC, NISZ LibreOffice Team
Details
Screenshot of the document after changing the whole paragraphs character style (125.20 KB, image/png)
2021-08-18 15:13 UTC, NISZ LibreOffice Team
Details
Screenshot of the document after rejecting the change (108.99 KB, image/png)
2021-08-18 15:14 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2021-08-18 15:12:38 UTC
Created attachment 174382 [details]
Example file from Writer

This is a followup to bug 50447
When a character style is set on a paragraph in some cases the change tracked modification of that to another character style does not restore the original character style.

Steps to reproduce:
    1. Open attached file, it contains a few paragraph of lorem ipsum formatted with Quotation character style and change tracking is enabled
    2. Triple click on a paragraph to highlight it entirely
    3. In the Navigator select another character style, such as Strong Emphasis; or a direct character formatting from the Formatting toolbar such as Underlined
    4. Reject the tracked change

Actual results:
The paragraphs character formatting becomes No character style.

Expected results:
The Quotation character formatting is restored.

LibreOffice details:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: dd3ab0fd737ff84657ff34eebafe2628f489e5a1
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 1 NISZ LibreOffice Team 2021-08-18 15:12:56 UTC
Created attachment 174383 [details]
Screenshot of the original document in Writer
Comment 2 NISZ LibreOffice Team 2021-08-18 15:13:14 UTC
Created attachment 174384 [details]
Screenshot of the document after changing the whole paragraphs character style
Comment 3 NISZ LibreOffice Team 2021-08-18 15:14:51 UTC
Created attachment 174385 [details]
Screenshot of the document after rejecting the change
Comment 4 László Németh 2021-08-25 06:43:32 UTC
tdf#143938 sw test: track format changes of the paragraph

Character formatting changes of the wholly selected
paragraph weren't tracked before the following fix:
commit 5e891c2ee82f2d7566ddb4e15b9c03cecb9fc1f8
"tdf#143939 sw: track format changes of the actual word".
This is only an unit test to cover both fixed problems.
Comment 5 Commit Notification 2021-08-25 06:44:26 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/400a44261c3891c1fb99b5339ada69cbc4777dd0

tdf#143938 sw test: track format changes of the paragraph

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 NISZ LibreOffice Team 2021-09-03 08:37:32 UTC
Verified in: 

Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d5ade739771ddf06cc7ee6d4af15672bfcf09ed6
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded