Bug 144028 - error strings in installation wizard still needed or not?
Summary: error strings in installation wizard still needed or not?
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.3.0.0 alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-23 13:04 UTC by sophie
Modified: 2021-08-25 11:07 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the dialog preview in Orca MSI authoring tool (65.40 KB, image/png)
2021-08-24 08:33 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sophie 2021-08-23 13:04:39 UTC
Hi,
string location: 
https://git.libreoffice.org/core/+/master/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf#473
Is this string still needed in LibreOffice?
Comment 1 Roman Kuznetsov 2021-08-24 08:20:55 UTC
Mike< what do you think about it?
Comment 2 Mike Kaganski 2021-08-24 08:33:41 UTC
Created attachment 174510 [details]
Screenshot of the dialog preview in Orca MSI authoring tool

OOO_CONTROL_206 is the placeholder string that is used for ErrorText control in SetupError dialog [1], which is defined as ErrorDialog [2] in the installer. This dialog is managed by Windows Installer [3], and the content of the ErrorText control is set by the service at runtime.

I believe that the reason why there is an explicit text there in Control.ulf is just to simplify testing of the dialog using e.g. Orca's dialog preview (see attachment).

I do not see a harm in its existence, and maybe it just needs a notice that it needs no translation.

[1] https://opengrok.libreoffice.org/xref/core/instsetoo_native/inc_openoffice/windows/msi_templates/Control.idt?r=6045232d#251
[2] https://opengrok.libreoffice.org/search?project=core&full=ErrorDialog
[3] https://docs.microsoft.com/en-us/windows/win32/msi/error-dialog
Comment 3 Roman Kuznetsov 2021-08-25 11:00:12 UTC
Let's close it then as NAB
Comment 4 sophie 2021-08-25 11:07:57 UTC
(In reply to Mike Kaganski from comment #2)

> I do not see a harm in its existence, and maybe it just needs a notice that
> it needs no translation.
> 
Thanks Mike for your explanations, so in that case, it should be removed from translation.