Created attachment 174520 [details] The original file saved by Writer This is a followup to bug 79069 When a table is deleted with change tracking enabled and the change contains paragraph text before/after the table, an empty table remains after accepting the change. Steps to reproduce: 1. Open attached file, it contains two tables among some text. The first table was deleted with the Delete table command, while the second was deleted by highlighting a sentence from the previous paragraph and extending the range to the following and pressing Delete. 2. Accept all tracked changes Actual results: The first table disappears correctly, the second does not. Expected results: The second table should be deleted as well. LibreOffice details: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 3ee22d95d3e1e9ce1d2ff8311e51d600179370f9 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win Locale: hu-HU (hu_HU); UI: en-US Calc: CL
Created attachment 174521 [details] The example file with changes visible
Created attachment 174522 [details] Screenshot of the problem in Writer after accepting all changes
Created attachment 174532 [details] the test document with track changes
Note: I was able to reproduce the problem only with the DOCX export/import. ODT export/import worked without any problem. The ODT test file has been attached.
tdf144058 sw track changes: fix table deletion at paragraph join Tracked paragraph join by table deletion left empty table in the text after accepting the changes, caused by the non-continuous redline range over the table, related to the copying of the formatting of the first paragraph to the (wholly or partially) removed paragraphs. Fixed by skipping paragraph format copying in the case of table paragraphs. Note: this is not enough for tables with inner redlines, where tracked paragraph join with deletion of such a table still leaves an empty table at the place of the table (a problem inherited from OOo). Regression from commit 1bbbe57dfc0b43d6b5444798d77dcdf5e4e76e49 "tdf#119571 change tracking: show layout changes at paragraph join".
László Németh committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f3bec764ddbf3fd3ae986f034c89626bf22940e0 tdf144058 sw track changes: fix table deletion at paragraph join It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Veriefid in: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: c2de581d1943df2d84f2b71817b6a8bee41f0217 CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: default; VCL: win Locale: hu-HU (hu_HU); UI: hu-HU Calc: threaded
Reviewing 7.3 release notes. Also verified as fixed on Ubuntu 18.04 with: Version: 7.3.0.1 / LibreOffice Community Build ID: 840fe2f57ae5ad80d62bfa6e25550cb10ddabd1d CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded