Bug 144107 - Editing: page breaks is not visible without gridlines
Summary: Editing: page breaks is not visible without gridlines
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.2.0.4 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.2.5 target:7.3....
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Sheet-Gridlines
  Show dependency treegraph
 
Reported: 2021-08-26 16:55 UTC by VLB
Modified: 2021-12-09 07:09 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
page break not visible (145.31 KB, application/pdf)
2021-08-27 08:40 UTC, VLB
Details
Example file (6.94 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-08-27 09:21 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description VLB 2021-08-26 16:55:54 UTC
Version: 7.2.0.4 (x64) / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 16; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL

The issue is reproduce by steps:
1- open blank sheet
2- make a page break and it will be visible
3- go to menu options-LO calc-image
4- set to hide at raterlines and click ok
5-page break is no longer visible
Comment 1 [REDACTED] 2021-08-26 17:42:41 UTC
Repro

Version: 7.2.0.4 / LibreOffice Community
Build ID: 9a9c6381e3f7a62afc1329bd359cc48accb6435b
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb)
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 2 [REDACTED] 2021-08-26 17:44:14 UTC
No repro in 

Version: 7.1.5.2 / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Timur 2021-08-27 08:26:21 UTC Comment hidden (obsolete)
Comment 4 VLB 2021-08-27 08:40:20 UTC
Created attachment 174573 [details]
page break not visible
Comment 5 Telesto 2021-08-27 09:21:46 UTC
Created attachment 174575 [details]
Example file

Repro
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: f58f35b2c8ca1efbacec642a8f3de5b0c499bc6b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 6 Buovjaga 2021-08-27 10:41:53 UTC
Bibisected with linux-64-7.2 to
https://git.libreoffice.org/core/commit/3092322bb83998397b09d3f34b6d04b5e5c1da50
lok: draw bgcolor lines for covering client grid...

Adding Cc: to Dennis Francis
Comment 7 Justin L 2021-11-27 15:40:40 UTC
This sounds like a revert candidate to me. The author is not responding at all, and a lot of "else" clauses have turned into "else if" clauses which could leave all kinds of other situations hanging.
Comment 8 Jan Holesovsky 2021-11-29 11:55:01 UTC
Justin: Sorry about the problem, I'll talk to Dennis to see what we can do.
Comment 9 Commit Notification 2021-12-01 10:11:46 UTC
Dennis Francis committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/307c1f13821386687b8cf3c560ff2570b89ac3a9

tdf#144107: fix incorrect conditioning on bGrid...

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Dennis Francis 2021-12-01 10:20:30 UTC
Backports to release branches:
https://gerrit.libreoffice.org/c/core/+/126134
https://gerrit.libreoffice.org/c/core/+/126135
Comment 11 Commit Notification 2021-12-01 15:59:35 UTC
Dennis Francis committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/7174f9ac911461e68badeac0e39ca3c2fd1abcef

tdf#144107: fix incorrect conditioning on bGrid...

It will be available in 7.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Buovjaga 2021-12-02 13:16:07 UTC
Verified, thanks (please change status)

Arch Linux 64-bit
Version: 7.4.0.0.alpha0+ / LibreOffice Community
Build ID: ac21d937690c1ef995df22e11384e0fab226472e
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 2 December 2021
Comment 13 Justin L 2021-12-02 14:09:28 UTC
(In reply to Buovjaga from comment #12)
> Verified, thanks (please change status)
Still waiting for the 7.3 backport to land, but yeah, it is fixed.
Comment 14 Christian Lohmaier 2021-12-06 13:30:00 UTC
7.2.4 was a hotfix release, updating target in status-whiteboard
Comment 15 Commit Notification 2021-12-09 07:09:09 UTC
Dennis Francis committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/fc839f3262254949fe96b408dec9094f7ef4fc88

tdf#144107: fix incorrect conditioning on bGrid...

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.