Bug 144419 - Horizontal Ruler Comments button issue if in Zoom Factor Optimal or Fit Width
Summary: Horizontal Ruler Comments button issue if in Zoom Factor Optimal or Fit Width
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.2.0.2 rc
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsUXEval
Depends on:
Blocks:
 
Reported: 2021-09-10 01:59 UTC by Eek! A Bug. Kill it!
Modified: 2021-09-30 12:38 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of optimal zoom with comments open and collapsed (11.60 KB, image/png)
2021-09-27 08:51 UTC, Heiko Tietze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eek! A Bug. Kill it! 2021-09-10 01:59:36 UTC
Description:
The Horizontal Ruler has a Comments button on the far right-hand side of the ruler if someone has inserted any comments in the document; however, if you have selected a Zoom Factor of Optimal, the Comments button WILL be hidden from view regardless of whether or not the Sidebar is open (likewise, it MAY be hidden if you have selected a Zoom Factor of Fit Width and the Sidebar is displayed, depending on how wide you opt to make the Sidebar). So, once you hide the comments with the Zoom Factor set to Optimal, you have no way to know that there are any comments associated with the document – unless you have the Navigator open, in which case you can see them with the Comments section expanded.

A side note (another related bug): If you have comments in a document and have the Navigator open, the Comments section will list all the comments. If you select a particular comment, right-click on it, a context menu of options appears. For some reason, Delete Delete (NOT a typo, the word Delete is repeated) appears. 

Steps to Reproduce:
1. Select a Writer document and set the Zoom Factor to Optimal (Sidebar displayed)
2. Insert a comment into the document
3. Toggle the Comments button to Hide the comments on the Horizontal Ruler

Actual Results:
The Comments button is NOT visible, so the comments cannot be toggled back on (although you can view them in the Comments section of Navigator. 

Expected Results:
The Comments button should be visible despite the Zoom Factor setting.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.2.0.2 (x64) / LibreOffice Community
Build ID: 614be4f5c67816389257027dc5e56c801a547089
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 1 Dieter 2021-09-25 04:38:46 UTC
I confirm the observation, but I'm not sure, if we should change this. It doesn't depend on optimal view. Comment button disappears, if you zoom in and area at the right of the page disappears. So I would say NAB, bug let's ask design-tam for further input and decision.

cc: Design-Team
Comment 2 S.Zosgornik 2021-09-26 23:00:31 UTC
 As the scenario demonstrates, next or inside the horizontal ruler is a very sub-optimal place for a button.
It also adds a single used concept to LibreOffice. In any case would I prefer the short-cut, the toolbar entry or the main menu in this order over the ruler and vote +1 to eradicate this nonsense.
Comment 3 Adolfo Jayme Barrientos 2021-09-27 07:21:09 UTC
It’s not just about a new toolbar button — a new control would also need to be designed and implemented for each of the Notebookbar modes…
Comment 4 Heiko Tietze 2021-09-27 08:51:07 UTC
Created attachment 175293 [details]
Screenshot of optimal zoom with comments open and collapsed

Fact is that "Optimal Zoom" ignores the new comments header when collapsed. Happens also with 115% (or the like) where you see only "Com".

Solution a) is to expand the visible area by the length of "Comments". We could also consider b) to introduce a small icon that would be visible after scrolling right. And c) optimal could be seen as hidden comments being hidden, ie. WF.
Comment 5 Heiko Tietze 2021-09-30 09:09:51 UTC
The issue was on the agenda for the design meeting but received no further input. 

View > Comments toggles the comments pane visibility and adjusts the optimal zoom accordingly. And "optimal" means to hide the pane when collapsed. This makes the request NAB. 

Feel free to reopen.
Comment 6 Adolfo Jayme Barrientos 2021-09-30 09:19:29 UTC
Sorry for not attending the meeting. A possible improvement would be to make the button collapse to an icon when there is not enough space, to avoid showing a clipped label "Co".
Comment 7 Heiko Tietze 2021-09-30 12:38:23 UTC
(In reply to Adolfo Jayme from comment #6)
>... possible improvement would be to make the button collapse to an icon

Comment 4, variant b). Too much effort, IMO, since you see the "Co" only after scrolling.