Bug 144420 - View > Zoom sub-menu should have the current state marked
Summary: View > Zoom sub-menu should have the current state marked
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: low minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError
Depends on:
Blocks: Main-Menu Zoom
  Show dependency treegraph
 
Reported: 2021-09-10 02:12 UTC by Eek! A Bug. Kill it!
Modified: 2022-09-08 04:58 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eek! A Bug. Kill it! 2021-09-10 02:12:32 UTC
Description:
View > Zoom opens a sub-menu that does not function like all the other menu items that have right-pointing arrows appended to them, which is to say with either a check mark inside a blue highlighted box or a blue highlighted icon if that particular option is selected. In other words, if you selected a Zoom Factor of Optimal, the icon associated with that selection is NOT highlighted in the sub-menu. If you do not have the Zoom icon displayed in the Standard Menu, then you have no way to easily tell what the Zoom & View Layout settings are for the document. So, for the sake of consistency, I think this should be corrected.

Steps to Reproduce:
1. Open a Writer document
2. Set Zoom Factor to Optimal
3. Go to View > Zoom


Actual Results:
Note that when the sub-menu for View > Zoom opens that it does NOT indicate that the Optimal View setting has been selected (as indicated by a blue highlighted box around the Optimal View selection).

Expected Results:
All menus and sub-menus should exhibit the same behavior for the sake of consistency, in other words, those selections with right-pointing arrows appended to them should either have a check mark inside a blue highlighted box or a blue highlighted icon if that particular option is selected. 


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.2.0.2 (x64) / LibreOffice Community
Build ID: 614be4f5c67816389257027dc5e56c801a547089
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 1 Dieter 2021-09-26 10:13:39 UTC Comment hidden (obsolete)
Comment 2 V Stuart Foote 2021-09-26 14:45:12 UTC
Confirmed.

All of the Zoom presets, including 'Optimal', are modal. The zoom setting should show as selected for the View -> Zoom submenu.

It should at least match the radio button behavior of the 'Zoom...' "Zoom & View Layout" dialog for the non-variable factors.

Version: 7.2.2.1 (x64) / LibreOffice Community
Build ID: 0e408af0b27894d652a87aa5f21fe17bf058124c
CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded
Comment 3 Eek! A Bug. Kill it! 2021-09-26 16:09:30 UTC
(In reply to Dieter from comment #1)
> Not sure, if I understand it correct:
> 
> Steps to reproduce:
> 1. Open a new document
> 2. Make sure, that "Optimal View" icon is part of the standard toolbar
> 3. Set Zoom Factor to Optimal with this icon
> 4. Go to View => Zoom
> 
> Actual result:
> Optimal view icon is not highlighted (same with icon in toolbar)
> 
> Expected result:
> Optimal view icon should be highlighted (same with icon in toolbar)
> 
> More general:
> Every setting in view submenu should be highlighted, if it is the current
> setting of the document.
> 
> EaK! A Bug, Kill it!, is this what you expect?
> => NEEDINFO



Your ‘Steps to reproduce’ are correct. The standard toolbar Zoom icon has a ‘Zoom & View Layout’ dialog that has a radio button for ‘Optimal Zoom Factor’. So, what I am saying is if you have selected the Optimal Zoom Factor (by any method) and then go to the View > Zoom, the submenu that pops up has eight selections – one of which is Optimal – and that icon is NOT highlighted in blue. Actually, it does not matter which option you choose, the icon associated with your selection does not indicate that you have selected it by being highlighted in blue. I should have pointed that out, but I tend to use Optimal almost exclusively. The point I was trying to make is that if you do not have the standard toolbar Zoom icon displayed, then you have no way to know which Zoom Factor is currently in use. You could go through the View > Zoom route, but without any of the eight icons highlighted in blue, you still have no idea which is currently in use (experienced users could make an educated guess, but a casual or new user would have no idea). I hope this clears it up.
Comment 4 Heiko Tietze 2021-09-27 08:57:05 UTC
Rather a nice top have to me than an urgent need. The zoom functions are kind of fire-and-forget but mutually exclusive settings that demand for radio buttons. In fact it's true that none of the options can be set in parallel to another at a checkmark wont be a violation.