Bug 144516 - Libreoffice icons / svg
Summary: Libreoffice icons / svg
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.6.2 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-15 08:39 UTC by bugzillolo
Modified: 2021-09-21 11:39 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot with black icons (172.94 KB, image/jpeg)
2021-09-15 08:39 UTC, bugzillolo
Details
screenshot with black icons2 (176.99 KB, image/jpeg)
2021-09-15 08:43 UTC, bugzillolo
Details
screenshot with black icons3 (174.75 KB, image/jpeg)
2021-09-15 08:43 UTC, bugzillolo
Details
Setup test skia (434.05 KB, application/vnd.oasis.opendocument.text)
2021-09-20 08:23 UTC, bugzillolo
Details
Windows setup (351.83 KB, application/vnd.oasis.opendocument.text)
2021-09-20 08:23 UTC, bugzillolo
Details
Skia log (158 bytes, text/plain)
2021-09-20 08:24 UTC, bugzillolo
Details
skia log 21.09.2021 (37 bytes, text/plain)
2021-09-21 07:21 UTC, bugzillolo
Details
Screenshot with skia options (153.40 KB, application/vnd.oasis.opendocument.text)
2021-09-21 09:16 UTC, bugzillolo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description bugzillolo 2021-09-15 08:39:10 UTC
Description:
With the latest versions, after years of using the same pc, using the default icon style (Colibri - automatic) when I open a new document the text and highlight color icons have a black background. If I set the icon in svg it doesn't happen.
I tried to boot into safe mode and everything works fine.
I have experimented with the various styles of icons and the problem always arises.

Steps to Reproduce:
1.open writer
2.open a new document
3.change icon style with svg

Actual Results:
the text and highlight color icons have a black background.

Expected Results:
icons have to be the same with the same style


Reproducible: Always


User Profile Reset: Yes



Additional Info:
for now I realized it only happens with those two icons (as you can see from the screenshot).
Comment 1 bugzillolo 2021-09-15 08:39:47 UTC
Created attachment 175029 [details]
screenshot with black icons
Comment 2 bugzillolo 2021-09-15 08:43:12 UTC
Created attachment 175030 [details]
screenshot with black icons2
Comment 3 bugzillolo 2021-09-15 08:43:29 UTC
Created attachment 175031 [details]
screenshot with black icons3
Comment 4 bugzillolo 2021-09-15 08:44:48 UTC
Version: 7.1.6.2 (x64) / LibreOffice Community
Build ID: 0e133318fcee89abacd6a7d077e292f1145735c3
CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Vulkan; VCL: win
Locale: it-IT (it_IT); UI: it-IT
Calc: CL


Nome dispositivo	DESKTOP-2GROP7E
Processore	Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz   3.41 GHz
RAM installata	8,00 GB (7,73 GB utilizzabile)
ID dispositivo	1F3BA441-A17D-4EA8-B5E9-D01BB5089DF9
ID prodotto	00330-50538-38138-AAOEM
Tipo sistema	Sistema operativo a 64 bit, processore basato su x64
Penna e tocco	Nessun input penna o tocco disponibile per questo schermo


Edizione	Windows 10 Pro
Versione	21H1
Data installazione:	‎19/‎07/‎2021
Build sistema operativo	19043.1237
Esperienza	Windows Feature Experience Pack 120.2212.3530.0
Comment 5 Julien Nabet 2021-09-15 19:05:21 UTC
Rizal: since it concerns icons, thought you might be interested in this one.
Comment 6 V Stuart Foote 2021-09-17 12:47:56 UTC
Does the icon background color resolve if you change from Skia/Vulkan to Skia/Raster (software rendering) from the Tools -> Options -> View panel?

Also, please provide the skia.log details from your profile cache. And what size in px screen are you working at?
Comment 7 bugzillolo 2021-09-20 08:18:57 UTC
Hello,
I don't know if I understand your question correctly.
I did some tests by changing the "skia" settings and I am attaching the results.
I understand that the problem is related to the "skia" setting that if activated creates the problem of the background of the icons.
Before, all this did not happen.
But what is the importance of this skia approach?
Do I have to keep it activated or "forced" or in the future will it be possible to stay with the standard settings if it was a bug?
Standard icons are best viewed as graphics when using l.o.
Comment 8 bugzillolo 2021-09-20 08:23:19 UTC
Created attachment 175132 [details]
Setup test skia
Comment 9 bugzillolo 2021-09-20 08:23:40 UTC
Created attachment 175133 [details]
Windows setup
Comment 10 bugzillolo 2021-09-20 08:24:08 UTC
Created attachment 175134 [details]
Skia log
Comment 11 V Stuart Foote 2021-09-20 13:26:45 UTC
(In reply to bugzillolo from comment #7)
> Hello,
> I don't know if I understand your question correctly.
> I did some tests by changing the "skia" settings and I am attaching the
> results.
> I understand that the problem is related to the "skia" setting that if
> activated creates the problem of the background of the icons.

Skia based rendering is the default rendering, the alternative is legacy GDI based rendering.  Skia has two modes, 1) Vulkan vector graphics support (replacing OpenGL hardware acceleration); 2) software only raster rendering

You are using the Vulkan mode of Skia. You can change to the software raster mode by the checkbox 'Forza il rendering del software Skia' and restarting LibreOffice.  Do the icons clear?

Alternatively, you can disable all Skia rendering. Uncheck 'Usa Skia per tutti i rendering' and restart LibreOffice.  Restart will be into GDI 'default' mode, do the icons clear then?

> Before, all this did not happen.
> But what is the importance of this skia approach?

It replaces the poorly supported OpenGL based GPU hardware acceleration of vector graphics. It also provides improved framework for raster based rendering compared to legacy default GDI calls. It is being implemented for all supported operating systems--i.e. it is cross platform

> Do I have to keep it activated or "forced" or in the future will it be
> possible to stay with the standard settings if it was a bug?
> Standard icons are best viewed as graphics when using l.o.

Maybe, although your Intel HD GRaphics 630 GPU should be well supported. Performance with Skia rendering (either mode) has proven reliable and more robust than GDI or previous OpenGL based libs. We are not going to revert its use.  Identifying bugs related to either Vulkan or raster based Skia implementation is ongoing to improve LibreOffices use of it cross platform.
Comment 12 bugzillolo 2021-09-20 14:56:35 UTC
(In reply to V Stuart Foote from comment #11)

> Skia based rendering is the default rendering, the alternative is legacy GDI
> based rendering.  Skia has two modes, 1) Vulkan vector graphics support
> (replacing OpenGL hardware acceleration); 2) software only raster rendering
> 
> You are using the Vulkan mode of Skia. You can change to the software raster
> mode by the checkbox 'Forza il rendering del software Skia' and restarting
> LibreOffice.  Do the icons clear?
> 
> Alternatively, you can disable all Skia rendering. Uncheck 'Usa Skia per
> tutti i rendering' and restart LibreOffice.  Restart will be into GDI
> 'default' mode, do the icons clear then?

Thanks a lot for the answer. I guess that the problem is more related to my hardware which is not very modern... or?
As you can see in the attachment "test setup", with the modification of the skia settings, in fact, the problem seems solved (with both settings changes)!


> It replaces the poorly supported OpenGL based GPU hardware acceleration of
> vector graphics. It also provides improved framework for raster based
> rendering compared to legacy default GDI calls. It is being implemented for
> all supported operating systems--i.e. it is cross platform

ok. it just seemed strange to me that with the same pc it didn't happen before (with the previous releases)

 
> Maybe, although your Intel HD GRaphics 630 GPU should be well supported.
> Performance with Skia rendering (either mode) has proven reliable and more
> robust than GDI or previous OpenGL based libs. We are not going to revert
> its use.  Identifying bugs related to either Vulkan or raster based Skia
> implementation is ongoing to improve LibreOffices use of it cross platform.

Ok !!! I understood! ;-)
I'll do some more testing in the next few days, but I think I'll use this setting you suggested: "You can change to the software raster mode by the checkbox 'Force Skia software render'".
One last question: to me as an end user, something changes in terms of usage or speed of l.o. using, or not, skia in its different ways?
What changes for me in practice?
Am I losing any advantage?
Comment 13 bugzillolo 2021-09-20 15:01:04 UTC
Or would you advise me to leave the default settings and use the "svg" interface of the same icon style?
With "svg" the icons appear to be normal (perhaps slightly less defined).
What are the differences?
For example, in a more modern PC that I use I must necessarily change the settings with "svg" to see the icons correctly (and not grainy), but I have never had the problems of "black icons" as on the PC of the "bug" that I reported.
Comment 14 V Stuart Foote 2021-09-20 15:32:30 UTC
(In reply to bugzillolo from comment #12)

> One last question: to me as an end user, something changes in terms of usage
> or speed of l.o. using, or not, skia in its different ways?
> What changes for me in practice?
> Am I losing any advantage?

Skia drivers and the Skia implementation in LibreOffice is being actively developed. While Vulkan vector hardware acceleration may be problematic with older hardware/driver pairs, the Skia raster rendering should be reliable and an improvement over GDI based rendering.  If Vulkan works with your GPU/driver combination, great use it!  If it has problems, be sure to update drivers and retest. If still has issues--disable it and use Skia raster rendering.

Only if both modes of Skia rendering have trouble--disable and use the default GDI rendering, just expect that it will be slower.

(In reply to bugzillolo from comment #13)
> Or would you advise me to leave the default settings and use the "svg"
> interface of the same icon style?
> With "svg" the icons appear to be normal (perhaps slightly less defined).
> What are the differences?
> For example, in a more modern PC that I use I must necessarily change the
> settings with "svg" to see the icons correctly (and not grainy), but I have
> never had the problems of "black icons" as on the PC of the "bug" that I
> reported.

The backing window for the two icons are redrawn dynamically depending on the color you've picked. They're not static. That they are black when you are using Skia Vulkan rendering is a glitch, but if that is the only glitch for an otherwise well supported GPU (like your Intel HD Grapchics 630) then keep using it (but do update the driver as Intel provides--the Vulkan and general Skia lib support is constantly being improved).  But if you are more comfortable (or if the GPU/driver pairing is given "Deny list" handling) just work in Skia software raster mode.
Comment 15 bugzillolo 2021-09-21 07:20:22 UTC
I set up the solution with skia and raster ("forza il rendering del software skia") and it seems to work perfectly!
It seems even faster than before !!! :-)
I attach the skia cache log.
I'm starting to think there was a recent update of an Intel driver in my pc that created this "problem" .. let's see what happens in the future ..
Can I still leave the settings as I put them now (skia and raster: "forza il rendering del software skia")?
Even if the drivers were to update?
Comment 16 bugzillolo 2021-09-21 07:21:09 UTC
Created attachment 175156 [details]
skia log 21.09.2021
Comment 17 bugzillolo 2021-09-21 09:16:10 UTC
Created attachment 175157 [details]
Screenshot with skia options

this is the screenshot of the settings I am using right now (as I explained earlier).
Comment 18 V Stuart Foote 2021-09-21 11:39:58 UTC
(In reply to bugzillolo from comment #17)
> Created attachment 175157 [details]
> Screenshot with skia options
> 
> this is the screenshot of the settings I am using right now (as I explained
> earlier).

OK, you are set to work with Skia/raster rendering. 

As updates occur, please recheck behavior of graphics with Skia/Vulkan rendering. The two icons may-or-maynot clear up.

For now let's resolve this => WFM, but feel free to reopen if in testing Skia/Vulkan, or working in Skia/raster, UI rendering becomes much worse.