Bug 144530 - Redo of the insertion of a textbox doesn't activate selected highlighting (which appears as redo isn't working)
Summary: Redo of the insertion of a textbox doesn't activate selected highlighting (wh...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Textbox Undo-Redo
  Show dependency tree / graph
 
Reported: 2021-09-16 07:20 UTC by Telesto
Modified: 2021-10-14 06:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2021-09-16 07:20:55 UTC 
Description:
Redo of the insertion of a textbox doesn't activate selected highlighting. Feedback is off: it appears as redo isn't working

Steps to Reproduce:
1. Open Writer
2. Cancel the wizard
3. Draw a textbox
4. Type something in it
5. Press CTRL+Z twice
6. Press CTRL+Y

Actual Results:
CTRL+Y does re-insert the textbox, but well hard to tell

Expected Results:
Maybe activate the textbox (mark it selected)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: d5e55d204b71710eb5eb5d2c683dd6698626df3c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2021-09-16 07:30:25 UTC 
Also in
Versie: 4.4.7.2 
Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
Locale: nl_NL

and in
Versie: 4.2.0.4 
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71

no undo of frame in
Versie: 4.1.0.4 
Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28

Adding bibisectRequest to see who did implement the feature.. need to be done once to get also an answer for bug 144531
Comment 2 yellowplane 2021-10-13 16:18:49 UTC 
I can reproduce in 

Version: 7.3.0.0.alpha0+ (x86) / LibreOffice Community
Build ID: d5e55d204b71710eb5eb5d2c683dd6698626df3c
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_US); UI: en-US
Calc: threaded

However, I'd like the UX team to give feedback.
Comment 3 Buovjaga 2021-10-13 18:36:37 UTC 
(In reply to Telesto from comment #1)
> Also in
> Versie: 4.4.7.2 
> Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600
> Locale: nl_NL
> 
> and in
> Versie: 4.2.0.4 
> Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71
> 
> no undo of frame in
> Versie: 4.1.0.4 
> Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28
> 
> Adding bibisectRequest to see who did implement the feature.. need to be
> done once to get also an answer for bug 144531

Undo started removing the frame in https://git.libreoffice.org/core/commit/12a4200e8ff7f045efcc7e9d15a24b15b248c437
Related: #i120498# Enhanced Undo/Redo and user experience...

Bibisected with Linux 42max.
Comment 4 Heiko Tietze 2021-10-14 05:55:03 UTC 
(In reply to Telesto from comment #0)
> CTRL+Y does re-insert the textbox, but well hard to tell
I don't see an issue.
 
> Expected Results:
> Maybe activate the textbox (mark it selected)
It is selected for me (7.2 and 7.3 VCL=kf5)
Comment 5 Heiko Tietze 2021-10-14 05:58:06 UTC 
(Tested with Writer and I understand selection in terms of the text box not the toolbar icon.)
Comment 6 Buovjaga 2021-10-14 06:11:49 UTC 
(In reply to Heiko Tietze from comment #5)
> (Tested with Writer and I understand selection in terms of the text box not
> the toolbar icon.)

Ah, the first step is wrong: it should be Impress, not Writer
Comment 7 Heiko Tietze 2021-10-14 06:23:30 UTC 
Yes, Impress could use Writer as blueprint and active the text box after redoing text input as Telesto suggests.