Description: Undo keeps the textbox insert button activated Steps to Reproduce: 1. Open Impress 2. Cancel the wizard 3. Draw a textbox 4. Type A 5. Press CTRL+Z twice 6. Look at the toolbar, notice textbox button being still activated 7. Try dragging new textbox -> Not working 8. Click textbox button again -> now it's working. Actual Results: Activated textbox button Expected Results: Disabled -> I want to insert new textbox, but Reproducible: Always User Profile Reset: No Additional Info: Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d5e55d204b71710eb5eb5d2c683dd6698626df3c CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Also in Versie: 4.4.7.2 Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 Locale: nl_NL and in Versie: 4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 no undo of frame in Versie: 4.1.0.4 Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 Adding bibisectRequest to see who did implement the feature..
Note: the identified commit will be same as for bug 144530
I can reproduce in Version: 7.3.0.0.alpha0+ (x86) / LibreOffice Community Build ID: d5e55d204b71710eb5eb5d2c683dd6698626df3c CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win Locale: en-GB (en_US); UI: en-US Calc: threaded However, I'd like the UX team to give feedback.
(In reply to Telesto from comment #1) > Also in > Versie: 4.4.7.2 > Build ID: f3153a8b245191196a4b6b9abd1d0da16eead600 > Locale: nl_NL > > and in > Versie: 4.2.0.4 > Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 > > no undo of frame in > Versie: 4.1.0.4 > Build ID: 89ea49ddacd9aa532507cbf852f2bb22b1ace28 > > Adding bibisectRequest to see who did implement the feature.. Undo started removing the frame in https://git.libreoffice.org/core/commit/12a4200e8ff7f045efcc7e9d15a24b15b248c437 Related: #i120498# Enhanced Undo/Redo and user experience... Bibisected with Linux 42max. Was an excruciating experience as the repo tends to be very crashy. This made it less annoying: while (git clean -f -X && git bisect skip && ! (SAL_USE_VCLPLUGIN=gen opt/program/soffice --impress --norestore)); do : ; done
Clearly a bug
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug