Bug 144728 - Writer hangs when you try delete a 25x1000 table
Summary: Writer hangs when you try delete a 25x1000 table
Status: RESOLVED DUPLICATE of bug 136238
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.1.2 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: implementationError, perf
Depends on:
Blocks: Writer-Tables
  Show dependency treegraph
 
Reported: 2021-09-25 19:54 UTC by Roman Kuznetsov
Modified: 2023-03-10 14:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Video of the Bug 144728 (1.79 MB, video/mp4)
2021-10-05 14:22 UTC, Lucile
Details
Lucile's computer specs 1 (30.11 KB, image/png)
2021-10-05 14:40 UTC, Lucile
Details
Lucile's computer specs 2 (display, graph card) (37.03 KB, image/png)
2021-10-05 14:41 UTC, Lucile
Details
Flamegraph (120.50 KB, image/svg+xml)
2023-03-10 14:40 UTC, Julien Nabet
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2021-09-25 19:54:07 UTC
Description:
Writer hangs when you try delete a 25x1000 table with numbering list in first column

Steps to Reproduce:
1. Open a new Writer document
2. Press Enter
3. Insert a table 25 columns x 1000 rows
4. Select a first column
5. Click a Numbering list icon on the toolbar => it adds a number into every cell in the column
6. Click anywhere inside the table
7. Click a Delete table icon on the Table toolbar => Writer hangs

If I try the same for table 17x1000 - Writer just deletes the table and works as should

Actual Results:
Writer hangs

Expected Results:
Writer deletes the table and works as should


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Version: 7.1.1.2 (x64) / LibreOffice Community
Build ID: fe0b08f4af1bacafe4c7ecc87ce55bb426164676
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL

Note: before 7.1 version you can't insert that huge table, there was a limitation for having only 16384 cells in table. So possibly it's a some implementation error?
Comment 1 Lucile 2021-10-05 14:22:02 UTC
Created attachment 175542 [details]
Video of the Bug 144728
Comment 2 Lucile 2021-10-05 14:23:19 UTC
I have managed to repro the issue on :

Version: 7.2.1.2 (x64) / LibreOffice Community
Build ID: 87b77fad49947c1441b67c559c339af8f3517e22
CPU threads: 16; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL


Description detail : 
After deleting a Table of 22columns x 978rows (Or 978columns and 22rows) or above, Libreoffice will hang indefinitely. 
The hang will require windows/Task manager intervention to forcefully close the program.


Upon relaunching Libreoffice, the option to recover the document is offered.
But if the table was containing any kind of data, everything will be lost by the user when recovering the document. 
(if the deleted button was pushed by mistake, it can result in the loss of a long work and sensitive data for the user) 


Testing attempts results : 

Deleting a table size of 22x978 or 978x22 will result in a hang , 
But Deleting any table bellow 22x978 (Like 21x978, 22x977 or 21x977 ...) will behave as intended.

Other combinations resulting in a hang : 19x1132, 20x1076, 21x1026

The issue occurs no matter if the program is running fullscreen or windowed.
 
Rows and columns numbers can be swapped but the result of the test will not be changed


I have narrowed down the repro steps to:  

1. Open a new Writer document
2. Insert a table of 22 columns x 978 rows (Or 978 columns and 22 rows)
3. Click anywhere inside the table
4. Click the Delete table icon on the Table toolbar => Writer hangs indefinitely
Comment 3 Lucile 2021-10-05 14:40:31 UTC
Created attachment 175543 [details]
Lucile's computer specs 1
Comment 4 Lucile 2021-10-05 14:41:08 UTC
Created attachment 175544 [details]
Lucile's computer specs 2 (display, graph card)
Comment 5 Xisco Faulí 2021-11-08 15:33:39 UTC
Hi Roman,
Do you also reproduce this issue with older versions of LibreOffice ?
Comment 6 Roman Kuznetsov 2021-11-08 16:21:34 UTC
(In reply to Xisco Faulí from comment #5)
> Hi Roman,
> Do you also reproduce this issue with older versions of LibreOffice ?

As I wrote in the description "Note: before 7.1 version you can't insert that huge table, there was a limitation for having only 16384 cells in table. So possibly it's a some implementation error?"
Comment 7 Roman Kuznetsov 2023-03-08 15:40:41 UTC
Julian, could you please try to create a perf graph for this problem?

The problem is still here in current 7.6 dev build
Comment 8 Julien Nabet 2023-03-09 18:22:16 UTC
On pc Debian x86-64 with master sources updated today, I can't reproduce this.

I mean, I followed the steps:
1. Open a new Writer document => OK
2. Press Enter => OK
3. Insert a table 25 columns x 1000 rows => OK but with this message:
"Warning: large tables may adversely affect performance and compatibility"
4. Select a first column => OK
5. Click a Numbering list icon on the toolbar => it adds a number into every cell 
=> I see that cells change but I see no number, I tried by selecting an item in "Toggle Ordered List" and also in "Select Outline Format".
I must have missed something obvious but don't know what.
Comment 9 Roman Kuznetsov 2023-03-09 20:20:25 UTC
(In reply to Julien Nabet from comment #8)
> On pc Debian x86-64 with master sources updated today, I can't reproduce
> this.
> ...
> I must have missed something obvious but don't know what.

Julien, please try a more simple way:

Create a table 25x1000 in new Writer document
Try delete it using Delete table icon on Table toolbar
Comment 10 Julien Nabet 2023-03-10 14:40:17 UTC
Created attachment 185894 [details]
Flamegraph

On pc Debian x86-64 with master sources updated today + gen rendering, I could reproduce this (I haven't waited until the end).
Here's the Flamegraph.
Comment 11 Julien Nabet 2023-03-10 14:47:31 UTC

*** This bug has been marked as a duplicate of bug 136238 ***