Bug 144970 - Adding chart with XTableCharts::addNewByName() fails if document's address syntax is Excel A1 or R1C1
Summary: Adding chart with XTableCharts::addNewByName() fails if document's address sy...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Eike Rathke
URL:
Whiteboard: target:7.3.0 target:7.2.3
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-06 15:50 UTC by Eike Rathke
Modified: 2021-10-08 14:16 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Test case document with macro. (13.07 KB, application/vnd.oasis.opendocument.spreadsheet)
2021-10-06 15:50 UTC, Eike Rathke
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eike Rathke 2021-10-06 15:50:48 UTC
Created attachment 175564 [details]
Test case document with macro.

Run macro to create chart with XTableCharts::addNewByName() in attached document with Excel A1 syntax, fails with IllegalArgumentException. Works with Calc A1 syntax.
Comment 1 Commit Notification 2021-10-06 21:16:24 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/34b01c95d4cab81cb614b67c47b004ac86d266f1

Resolves: tdf#144970 Chart CellRangeRepresentation expects UI representation

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Commit Notification 2021-10-07 10:53:35 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/14f81ca6ad289bf86781f642aa129b33151247cf

Related: tdf#144970 == ScRefFlags::ZERO is not a replacement for != 0 ...

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2021-10-07 10:53:45 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/852292feee08b4d256f8255926e1f84b4c6fd4b6

Related: tdf#144970 Make Drag&Drop of Chart range work with UI representation

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Eike Rathke 2021-10-07 11:06:31 UTC
Pending review https://gerrit.libreoffice.org/c/core/+/123211 for 7-2
Comment 5 Commit Notification 2021-10-08 11:04:21 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ec20aee719aef1ff6fec6e09685dafcfd28fb2a7

tdf#144970: sc_macros_test: Add unittest

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-10-08 14:16:00 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/cf4dbb7c1287d5b3fe7870fc0aaa172a5d444515

Resolves: tdf#144970 Chart CellRangeRepresentation expects UI representation

It will be available in 7.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.